feat: implement config cache-proxy command by tisutisu · Pull Request #54 · konflux-ci/konflux-build-cli

tisutisu · 2026-02-09T05:52:03Z

This PR implements the konflux-build-cli config cache-proxy --enable <true/false> cmd, to be used during build-definitions init task replacement using golang CLI.

snyk-io · 2026-02-09T05:52:17Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

tkdchen · 2026-02-09T07:51:30Z

pkg/commands/cache_proxy.go

+	l.Logger.Infof("cluster-config config map data: %v", cm.Data)
+	allowCache = cm.Data["allow-cache-proxy"]
+	if allowCache == "true" {
+		httpProxy = cm.Data["http-proxy"]
+		noProxy = cm.Data["no-proxy"]
+	} else {
+		httpProxy = ""
+		noProxy = ""
+	}


Should this piece of code in else branch?

Otherwise setting default*Proxy has no effect. They are reassigned by reading http-proxy and no-proxy from cm.Data.

have felt this same while writing the logic, but kept the logic same as per the current bash implementation here

The below if-else is relative to the link you mentioned.

https://github.com/konflux-ci/build-definitions/blob/a91adc4f10bf5dc684fe32b373fd718253945cd4/task/init/0.3/init.yaml#L44-L61 is relative to the commented lines I think. Code from line 44 to 61 has this logic:

if configmap is present, http_proxy and no_proxy are assigned according to the config data.

if configmap is not present, use the defaults.

Got your point now, thanks for catching it.
Addressed it on the latest commit 787fee7

tkdchen

Maybe we can also wrap kubectl (it's included in task-runner) command instead of calling kubenetes APIs, which is similar with other nested commands. Invoking kubectl could also help us having less effort on maintaining dependencies updates.

tisutisu · 2026-02-10T06:56:15Z

Maybe we can also wrap kubectl (it's included in task-runner) command instead of calling kubenetes APIs, which is similar with other nested commands. Invoking kubectl could also help us having less effort on maintaining dependencies updates.

@tkdchen even if we use cli, for reading/unmarshalling of kubectl cmd outputs, we need to depend on the kubernetes pkgs like k8s.io/api/core/v1, otherwise we have to duplicate code in our own implementation for reading ConfigMaps, not sure if we should go with wrapper around kubectl. WDYT?

cmd/config/cache_proxy.go

pkg/clients/kubernetes_test.go

pkg/commands/cache_proxy.go

mmorhun

This might be out of scope of this PR, but it anyway blocks it.
The main problem is that we accessing k8s cluster directly from within CLI making it tightly bound and dependent on k8s environment, making it impossible to run without a cluster, say locally or in another than Tekton CI. (Obviously, there are workarounds, but we need a proper solution).

My suggestion is to create a abstraction layer, say ConfigReader that would detect the environment (easiest is to use env var) and then read k8s resources if run within k8s cluster or access config in different source (say ini or env file) otherwise.

cmd/config/cache_proxy.go

pkg/clients/kubernetes.go

pkg/commands/cache_proxy.go

mmorhun

I think we need ConfigReader interface with a factory (NewConfigReader) that constructs required implementation (K8sConfigReader or EnvFileConfigReader) based on an env var (if not set, k8s is the default). Then config command(s) can use it.

cmd/config/cache_proxy.go

pkg/appconfig/config_map_reader.go

mmorhun · 2026-02-17T08:14:32Z

pkg/commands/cache_proxy.go

+		Usage:      "Whether to enable cache proxy or not. Required.",
+		Required:   true,
+	},
+	"config-file": {


Since the config contains global platform setting and not only proxy config, I think that should be configured on the ConfigReader level via an env var.

Updated the code to read from a platform config file named PLATFORM_CONFIG_FILE from the env.

os.Getenv("PLATFORM_CONFIG_FILE")

PTAL again.

mmorhun · 2026-02-17T08:53:48Z

pkg/commands/cache_proxy.go

+	configMapNamespace = "cluster-config"
+	configMapName      = "konflux-info"


Those are properties of k8sConfigReader

mmorhun · 2026-02-17T08:54:57Z

pkg/commands/cache_proxy.go

+	defaultHttpProxy   = "squid.caching.svc.cluster.local:3128"
+	defaultNoProxy     = "brew.registry.redhat.io,docker.io,gcr.io,ghcr.io,images.paas.redhat.com,mirror.gcr.io,nvcr.io,quay.io,registry-proxy.engineering.redhat.com,registry.access.redhat.com,registry.ci.openshift.org,registry.fedoraproject.org,registry.redhat.io,registry.stage.redhat.io,vault.habana.ai"


I'd prefer to not to have such defaults here, but have them in the Tekton task env.

mmorhun · 2026-02-17T08:56:23Z

pkg/commands/cache_proxy.go

+		if err != nil {
+			return err
+		}
+		c.Configs.ConfigReader = &config.K8sConfigMapReader{Name: configMapName, Namespace: configMapNamespace, Clientset: clientset}


We should have something like:

ConfigReader = NewConfigReader()

in the command constructor.

mmorhun · 2026-02-17T08:57:30Z

pkg/commands/cache_proxy.go

+	c.logParams()
+
+	l.Logger.Debug("Reading config-map data")
+	cmData, err := c.Configs.ConfigReader.ReadConfigData()


nitpick: instead of cmData, it's better to have configData or something like that (to not to have hard k8s connection)

Renamed it to cacheProxyConfig now. agnostic of k8s connection.

mmorhun · 2026-02-17T08:57:55Z

pkg/commands/cache_proxy.go

+		}
+	}
+
+	// Apply ENABLE_CACHE_PROXY check (from task param) ONLY if cluster allows it


Better say if backend allows it and say, for example, k8s cluster.

mmorhun · 2026-02-17T09:01:26Z

pkg/config/config_map_reader.go

+
+// ReadConfigData reads the YAML file, unmarshals it and returns the config data from the configmap.
+func (y *YAMLFileReader) ReadConfigData() (map[string]string, error) {
+


nitpick: Extra empty line

mmorhun · 2026-02-17T09:05:34Z

pkg/config/config_map_reader.go

+		return nil, fmt.Errorf("failed to read file %s: %w", y.FilePath, err)
+	}
+
+	configMap := corev1.ConfigMap{}


Let's assume that the command runs in non k8s environment. How comfortable it is to deal with k8s config map in such an environment (e.g. GitHub action?) to provide the config?

now reading from an ini file.

mmorhun · 2026-02-23T15:26:49Z

pkg/commands/cache_proxy.go

+	if err != nil {
+		return nil, err
+	}
+


Looks like a leftover

mmorhun · 2026-02-23T15:27:24Z

pkg/commands/cache_proxy.go

+	return cacheProxy, nil
+}
+
+func (c *CacheProxy) initializeConfigs() error {


Not sure that we need a separate function for creating an instance of ConfigReader

mmorhun · 2026-02-23T15:29:01Z

pkg/commands/cache_proxy.go

+		l.Logger.Warnf("Error while reading config map: %s", err.Error())
+		// ConfigMap missing, use defaults


The command should know nothing about ConfigMaps

mmorhun · 2026-02-23T15:38:18Z

pkg/config/config_reader.go

+		if err != nil {
+			return nil, err
+		}
+		return &K8sConfigMapReader{Name: "cluster-config", Namespace: "konflux-info", Clientset: clientset}, nil


Should those be configurable via env vars too with the above defaults?

mmorhun · 2026-02-23T15:47:48Z

pkg/config/config_reader.go

+	"k8s.io/client-go/kubernetes"
+)
+
+type CacheProxyConfig struct {


Since we are reading config from "konflux-info", should the struct have a generic name?

mmorhun · 2026-02-23T15:53:54Z

testdata/sample-platform-config.ini

@@ -0,0 +1,5 @@
+[cache-proxy]


Does it make sense to create this file in tempdir from tests?

tisutisu requested a review from a team as a code owner February 9, 2026 05:52

tisutisu force-pushed the implement-init-cmd branch from cd0ef36 to 5e3688a Compare February 9, 2026 07:12

tkdchen reviewed Feb 9, 2026

View reviewed changes

mmorhun reviewed Feb 10, 2026

View reviewed changes

mmorhun reviewed Feb 11, 2026

View reviewed changes

tisutisu force-pushed the implement-init-cmd branch 2 times, most recently from eddf14f to 8d1f0fd Compare February 16, 2026 13:35

mmorhun reviewed Feb 16, 2026

View reviewed changes

cmd/config/cache_proxy.go Outdated Show resolved Hide resolved

pkg/appconfig/config_map_reader.go Outdated Show resolved Hide resolved

pkg/appconfig/config_map_reader.go Outdated Show resolved Hide resolved

tisutisu force-pushed the implement-init-cmd branch 3 times, most recently from fa990a8 to d53204e Compare February 17, 2026 06:36

mmorhun reviewed Feb 17, 2026

View reviewed changes

tisutisu added 2 commits February 23, 2026 13:34

implement config cache-proxy cmd

00e91de

address review comments

cc6af4b

tisutisu force-pushed the implement-init-cmd branch from d53204e to cc6af4b Compare February 23, 2026 08:04

fix: go mod tidy

f87a6a6

mmorhun reviewed Feb 23, 2026

View reviewed changes

		configMapNamespace = "cluster-config"
		configMapName = "konflux-info"

		defaultHttpProxy = "squid.caching.svc.cluster.local:3128"
		defaultNoProxy = "brew.registry.redhat.io,docker.io,gcr.io,ghcr.io,images.paas.redhat.com,mirror.gcr.io,nvcr.io,quay.io,registry-proxy.engineering.redhat.com,registry.access.redhat.com,registry.ci.openshift.org,registry.fedoraproject.org,registry.redhat.io,registry.stage.redhat.io,vault.habana.ai"


		// ReadConfigData reads the YAML file, unmarshals it and returns the config data from the configmap.
		func (y *YAMLFileReader) ReadConfigData() (map[string]string, error) {

		l.Logger.Warnf("Error while reading config map: %s", err.Error())
		// ConfigMap missing, use defaults

Comments

Conversation

tisutisu commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snyk-io bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tisutisu Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tkdchen Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tisutisu Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tkdchen left a comment

Choose a reason for hiding this comment

Uh oh!

tisutisu commented Feb 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmorhun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmorhun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tisutisu Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tisutisu commented Feb 9, 2026 •

edited

Loading

snyk-io bot commented Feb 9, 2026 •

edited

Loading

tisutisu Feb 9, 2026 •

edited

Loading

tkdchen Feb 9, 2026 •

edited

Loading

tisutisu Feb 9, 2026 •

edited

Loading

tisutisu Feb 23, 2026 •

edited

Loading

tisutisu Feb 23, 2026 •

edited

Loading