Skip to content

build: Use normalized platform spec for ARG expansion #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slimreaper35 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Use normalized platform spec for ARG expansion #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/commands/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ func (c *Build) parseContainerfile() (*dockerfile.Dockerfile, error) {
func (c *Build) createBuildArgExpander() (dockerfile.SingleWordExpander, error) {
// Define built-in ARG variables
// See https://docs.docker.com/build/building/variables/#multi-platform-build-arguments
platform := platforms.DefaultSpec()
platform := platforms.Normalize(platforms.DefaultSpec())
args := map[string]string{
// We current don't explicitly expose the --platform flag, so the TARGET* values always
// match the BUILD* values. If we add --platform handling, we would want to respect it here.
Expand Down