Skip to content

Comments

fix(ROK-1480): correct release count position on release monitor#683

Open
akshay808 wants to merge 3 commits intokonflux-ci:mainfrom
akshay808:fix/ROK-1480-release-count-position
Open

fix(ROK-1480): correct release count position on release monitor#683
akshay808 wants to merge 3 commits intokonflux-ci:mainfrom
akshay808:fix/ROK-1480-release-count-position

Conversation

@akshay808
Copy link
Contributor

@akshay808 akshay808 commented Feb 5, 2026

Fixes

https://issues.redhat.com/browse/ROK-1480

Description

This change fixes the incorrect placement of the total release count on the Release Monitor page.

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Summary by CodeRabbit

  • Refactor
    • Moved the total release count from the table header into a labeled count beneath the toolbar for clearer layout.
    • Removed the empty count column from table rows to simplify the table structure.
    • Table header no longer displays a trailing pluralized total; the count is now shown in the toolbar area.

@snyk-io
Copy link
Contributor

snyk-io bot commented Feb 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'version', 'include', 'exclude', 'rules', 'limits'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f35a1a4 and 11903b8.

📒 Files selected for processing (1)
  • src/components/ReleaseMonitor/ReleaseMonitorListView.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/ReleaseMonitor/ReleaseMonitorListView.tsx

📝 Walkthrough

Walkthrough

Removed the count column and total-count header from the Release Monitor table; rows no longer include an empty count cell; the release count is now displayed as a pluralized Label in the toolbar; header construction and related types/signatures were simplified accordingly.

Changes

Cohort / File(s) Summary
Header updates
src/components/ReleaseMonitor/ReleaseListHeader.tsx
Removed the count key from releaseTableColumnClasses, updated ReleaseMonitorColumnKey type, and changed getReleasesListHeader signature to drop the totalCount parameter; header now returns createTableHeaders(releaseColumns) directly.
Row updates
src/components/ReleaseMonitor/ReleaseListRow.tsx
Removed the empty/count <TableData> cell from each row, aligning row cells with the simplified header.
Toolbar count display
src/components/ReleaseMonitor/ReleaseMonitorListView.tsx
Added PF Flex, FlexItem, Label and pluralize usage to render the pluralized release count in the toolbar; removed sortedFilteredData.length from getReleasesListHeader call and simplified hook dependencies.

Sequence Diagram(s)

(omitted — changes are UI/structure adjustments without altered multi-component control flow)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • testcara
  • rrosatti

A tiny column waved goodbye today,
Rows grew leaner, headers found their way.
Count now sits atop the toolbar bright,
Tables trimmed, alignment set just right. 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving the release count from the table header to the toolbar area, which is a positioning correction for the Release Monitor page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.73%. Comparing base (ec8399b) to head (11903b8).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   86.52%   86.73%   +0.21%     
==========================================
  Files         761      771      +10     
  Lines       57879    58862     +983     
  Branches     6807     7070     +263     
==========================================
+ Hits        50079    51054     +975     
+ Misses       7587     7586       -1     
- Partials      213      222       +9     
Flag Coverage Δ
e2e 41.75% <ø> (-0.29%) ⬇️
unittests 85.94% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/components/ReleaseMonitor/ReleaseListHeader.tsx 100.00% <100.00%> (ø)
src/components/ReleaseMonitor/ReleaseListRow.tsx 22.61% <ø> (+1.02%) ⬆️
...mponents/ReleaseMonitor/ReleaseMonitorListView.tsx 96.06% <100.00%> (+0.11%) ⬆️

... and 94 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8399b...11903b8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@testcara testcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tests locally, it works as expected.

Copy link
Member

@rrosatti rrosatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good, but I'm not able to test locally. I'm getting a "something went wrong" error, looks like it's because of the multiple calls from several namespaces:

Screenshot 2026-02-05 at 10 45 04

@akshay808 akshay808 requested a review from a team as a code owner February 17, 2026 12:36
@akshay808 akshay808 requested review from abhinandan13jan, rrosatti and testcara and removed request for a team February 17, 2026 12:36
/>
<Flex justifyContent={{ default: 'justifyContentFlexEnd' }}>
<FlexItem>
<Label
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when testing locally, I noticed the position of the count label is different from the screenshot in the PR's description. Shouldn't it be placed on top of MonitoredReleasesFilterToolbar?

also, I'd add some right margin, because at the moment it's too close to the scroll bar :)

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the position of the release count after discussing it with Chuang Cao (my team lead). As per his suggestion, the release count position has been aligned according to the attached image.

Additionally, I have added the right margin to the release count as mentioned in the review comments.

I have also updated the pull request screenshot based on our latest discussion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshay808 have you pushed the changes? I don't see the margin right difference 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, yesterday code push has been failed i thought it was successful. Now successfully updated the code you can check now

@rrosatti rrosatti added the ok-to-test Enables E2E tests to run on PRs from contributors. label Feb 23, 2026
@akshay808 akshay808 requested a review from rrosatti February 23, 2026 17:51
Copy link
Member

@rrosatti rrosatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Enables E2E tests to run on PRs from contributors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants