fix(ROK-1480): correct release count position on release monitor#683
fix(ROK-1480): correct release count position on release monitor#683akshay808 wants to merge 3 commits intokonflux-ci:mainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Header updates src/components/ReleaseMonitor/ReleaseListHeader.tsx |
Removed the count key from releaseTableColumnClasses, updated ReleaseMonitorColumnKey type, and changed getReleasesListHeader signature to drop the totalCount parameter; header now returns createTableHeaders(releaseColumns) directly. |
Row updates src/components/ReleaseMonitor/ReleaseListRow.tsx |
Removed the empty/count <TableData> cell from each row, aligning row cells with the simplified header. |
Toolbar count display src/components/ReleaseMonitor/ReleaseMonitorListView.tsx |
Added PF Flex, FlexItem, Label and pluralize usage to render the pluralized release count in the toolbar; removed sortedFilteredData.length from getReleasesListHeader call and simplified hook dependencies. |
Sequence Diagram(s)
(omitted — changes are UI/structure adjustments without altered multi-component control flow)
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
- feat(release-monitor): Release Monitor: add ‘releases’ count column (table is virtualized) #442: Modifies the same header/column APIs (adds/removes
countcolumn and total-count header). - feat: refactoring the konflux release dashboard #379: Edits
ReleaseListHeader/row rendering and overlaps with these table/header changes. - feat: add columns product and product version #622: Adjusts Release Monitor column definitions and row rendering in a way that may conflict or interact with these edits.
Suggested reviewers
- testcara
- rrosatti
A tiny column waved goodbye today,
Rows grew leaner, headers found their way.
Count now sits atop the toolbar bright,
Tables trimmed, alignment set just right. 🎉
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately describes the main change: moving the release count from the table header to the toolbar area, which is a positioning correction for the Release Monitor page. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
- 📝 Generate docstrings (stacked PR)
- 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
+ Coverage 86.52% 86.73% +0.21%
==========================================
Files 761 771 +10
Lines 57879 58862 +983
Branches 6807 7070 +263
==========================================
+ Hits 50079 51054 +975
+ Misses 7587 7586 -1
- Partials 213 222 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 94 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
testcara
left a comment
There was a problem hiding this comment.
lgtm, tests locally, it works as expected.
| /> | ||
| <Flex justifyContent={{ default: 'justifyContentFlexEnd' }}> | ||
| <FlexItem> | ||
| <Label |
There was a problem hiding this comment.
There was a problem hiding this comment.
I have updated the position of the release count after discussing it with Chuang Cao (my team lead). As per his suggestion, the release count position has been aligned according to the attached image.
Additionally, I have added the right margin to the release count as mentioned in the review comments.
I have also updated the pull request screenshot based on our latest discussion.
There was a problem hiding this comment.
@akshay808 have you pushed the changes? I don't see the margin right difference 🤔
There was a problem hiding this comment.
Apologies, yesterday code push has been failed i thought it was successful. Now successfully updated the code you can check now


Fixes
https://issues.redhat.com/browse/ROK-1480
Description
This change fixes the incorrect placement of the total release count on the Release Monitor page.
Screen shots / Gifs for design review
Browser conformance:
Summary by CodeRabbit