fix(KFLUXUI-1032): do not remove app when periodic stage e2e test fail

[JoaoPedroPP]

Assisted-by: Cursor

Fixes

KFLUXUI-1032

Description

Do not remove konflux ui app when periodic e2e stage test fails. Currently we chekcing for PERIODIC_RUN_STAGE variable from cypress.config.ts but on the periodic stage test it is set the variable JOB_TYPE that we can use to check what kind of test is running.

Type of change

• Feature
• Bugfix
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Summary by CodeRabbit

• Tests
  • Updated test skip logic to use environment variable truthiness checking instead of exact string comparison for improved flexibility in test execution.

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'version', 'include', 'exclude', 'rules', 'limits'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

📝 Walkthrough

Walkthrough

A conditional check in the e2e test was modified to evaluate the PERIODIC_RUN_STAGE environment variable based on truthiness instead of strict string comparison to 'true', potentially altering test skip behavior.

Changes

Cohort / File(s)	Summary
Test Configuration Logic e2e-tests/tests/basic-happy-path.spec.ts	Modified the skip condition for the "Delete the application via UI" setup from checking strict string equality (=== 'true') to truthiness evaluation (Cypress.env('PERIODIC_RUN_STAGE')), changing behavior to skip deletion whenever the environment variable is set to any truthy value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• test(KFLUXUI-324): flaky test app removal #607: Modifies the same "Delete the application via UI" flow in the basic-happy-path test file with related cleanup/deletion changes.
• fix: periodic jobs config #576: Also changes strict 'true' string checks to truthiness-based evaluation of the PERIODIC_RUN_STAGE environment flag.
• fix(KFLUXUI-1032): keep application if it fails on stage #699: Modifies deletion-skip logic in the same test file and relies on PERIODIC_RUN_STAGE conditional logic.

Suggested reviewers

• Katka92
• testcara
• rrosatti
• milantaky

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main fix: preventing app removal when periodic stage e2e tests fail, which matches the PR's core objective and the code change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch KFLUXUI-1032

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@e2e-tests/tests/basic-happy-path.spec.ts`:
- Line 222: The conditional in the test cleanup uses a truthy check on
Cypress.env('PERIODIC_RUN_STAGE') which misinterprets the string 'false' as
true; update the condition in the block that checks hasTestFailed and
Cypress.env('PERIODIC_RUN_STAGE') (the line with if (hasTestFailed &&
Cypress.env('PERIODIC_RUN_STAGE')) {) to perform an explicit string comparison
against 'true' (i.e., check Cypress.env('PERIODIC_RUN_STAGE') === 'true') so
deletion only runs when the env explicitly equals 'true'.

---

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8a8dde and b1fccb8.

📒 Files selected for processing (1)

• e2e-tests/tests/basic-happy-path.spec.ts

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.14%. Comparing base (d8a8dde) to head (b1fccb8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   87.23%   87.14%   -0.10%     
==========================================
  Files         764      764              
  Lines       58225    58225              
  Branches     5658     6879    +1221     
==========================================
- Hits        50795    50741      -54     
+ Misses       7376     7359      -17     
- Partials       54      125      +71     

Flag	Coverage Δ
e2e	45.74% <ø> (-4.35%)	⬇️
unittests	85.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 65 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a8dde...b1fccb8. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rrosatti]

LGTM