feat(ISV-5783): Use new SBOM generation workflow#950
feat(ISV-5783): Use new SBOM generation workflow#950johnbieren merged 1 commit intokonflux-ci:developmentfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
/ok-to-test |
|
/retest |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@konflux-ci/release-service-maintainers The E2E tests are not cooperating, could you please take a look in the meantime? |
I will review later today. Meanwhile, Scott merged another PR that changed the pipeline, so you will need to resolve conflicts (likely just the version and readme). |
mmalina
left a comment
mmalina
left a comment
There was a problem hiding this comment.
A few small comments, but overall it looks good.
jedinym
force-pushed
the
ISV-5783
branch
2 times, most recently
from
d30620b to
df4f05c
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Blocked by konflux-ci/release-service-utils#436 |
jedinym
force-pushed
the
ISV-5783
branch
3 times, most recently
from
4f0337d to
6d5c777
Compare
|
@konflux-ci/release-service-maintainers Once the release-service-utils release is resolved, this PR is ready to merge. It's important for us that we get this into staging today. |
You don't even have passing unit tests |
jedinym
force-pushed
the
ISV-5783
branch
2 times, most recently
from
6ff7cde to
601f1cb
Compare
|
@konflux-ci/release-service-maintainers could you please try rerunning the GH actions? |
Triggered now. I noticed these issues with github assigning runners elsewhere too. |
|
Noting that this has passing e2e right now so once the README thing is fixed and it is rebased, we should be able to merge without e2e |
|
Can you squash the commits when you rebase? |
mmalina
left a comment
mmalina
left a comment
There was a problem hiding this comment.
LGTM, once Johnny's remaining thread is addressed.
The SBOM generation logic is now dependent on fewer tasks. Signed-off-by: Martin Jediny <jedinym@proton.me>
|
Merging without waiting for e2e, as it had passing e2e and only a text file changed |
The SBOM generation logic is now dependent on fewer tasks. Signed-off-by: Martin Jediny <jedinym@proton.me>
4 participants
With the refactoring of the SBOM generation process (konflux-ci/release-service-utils#418, konflux-ci/release-service-utils#415, konflux-ci/release-service-utils#399), we can simplify the
rh-advisoriespipeline.The SBOM generation task are now only dependent on
apply-mapping.Changes
populate-release-notesTask no longer generates data used to generate SBOMs.push-rpm-data-to-pyxisTask no longer exports a result with the SBOM directory.update-component-sbomTask is no longer dependent onpopulate-release-notesandpush-rpm-data-to-pyxis.create-product-sbomTask is no longer dependent onpopulate-release-notes.Relevant Jira
https://issues.redhat.com/browse/ISV-5783