feat(RELEASE-2092): get snapshot from kubearchive if deleted#657
Merged
querti merged 1 commit intokonflux-ci:mainfrom Feb 17, 2026
Merged
feat(RELEASE-2092): get snapshot from kubearchive if deleted#657querti merged 1 commit intokonflux-ci:mainfrom
querti merged 1 commit intokonflux-ci:mainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
querti
added a commit
to querti/release-service-catalog
that referenced
this pull request
Feb 12, 2026
The catalog tasks mostly use the get-resource script in release-utils-repo to get Kubernetes resources. For snapshots, this script has been modified to fallback to kubearchive if the resource had been deleted [1]. This approach doesn't work if the get-resource script isn't used to get the snapshot. This commit modifies the one instance where this happens to use the get-resource script, ensuring that the kubearchive fallback is used. [1] konflux-ci/release-service-utils#657 Assisted-by: Cursor Signed-off-by: Lubomir Gallovic <lgallovi@redhat.com>
Contributor
Author
|
There is also a related PR in the catalog repo that ensures that this script is used for every instance of getting the snapshot: konflux-ci/release-service-catalog#1986 |
Modify the get-resource script to fallback to kubearchive if the resource is deleted. This functionality is restricted to snapshots since I don't know the side effects if it was enabled for every resource. But theoretically it can be enabled for other resources as well. Kubearchive needs to be configured before it can be used. The script performs the configuration - it is semi-automatic, the resources are gathered from kubectl config + cluster by the interactive script. Temporary kubearchive config file is used (in the /tmp dir) so that the script would work in container/kubernetes environment and so that it wouldn't interfere with the hosts environment. The script allows jsonpath, but this is not supported by kubearchive. To simulate the functionality, jq is used for kubearchive. jq is different from kubernetes jsonpath, so some substitutions had to be used. It will work for the common cases (the ones found in release-service catalog), but it may break if a more complex expression is used. Assisted-by: Cursor Signed-off-by: Lubomir Gallovic <lgallovi@redhat.com>
e06a99b to
2d3f3da
Compare
querti
added a commit
to querti/release-service-catalog
that referenced
this pull request
Feb 12, 2026
The catalog tasks mostly use the get-resource script in release-utils-repo to get Kubernetes resources. For snapshots, this script has been modified to fallback to kubearchive if the resource had been deleted [1]. This approach doesn't work if the get-resource script isn't used to get the snapshot. This commit modifies the one instance where this happens to use the get-resource script, ensuring that the kubearchive fallback is used. [1] konflux-ci/release-service-utils#657 Assisted-by: Cursor Signed-off-by: Lubomir Gallovic <lgallovi@redhat.com>
querti
added a commit
to querti/release-service-catalog
that referenced
this pull request
Feb 12, 2026
The catalog tasks mostly use the get-resource script in release-utils-repo to get Kubernetes resources. For snapshots, this script has been modified to fallback to kubearchive if the resource had been deleted [1]. This approach doesn't work if the get-resource script isn't used to get the snapshot. This commit modifies the one instance where this happens to use the get-resource script, ensuring that the kubearchive fallback is used. [1] konflux-ci/release-service-utils#657 Assisted-by: Cursor Signed-off-by: Lubomir Gallovic <lgallovi@redhat.com>
happybhati
approved these changes
Feb 16, 2026
querti
added a commit
to querti/release-service-catalog
that referenced
this pull request
Feb 17, 2026
The catalog tasks mostly use the get-resource script in release-utils-repo to get Kubernetes resources. For snapshots, this script has been modified to fallback to kubearchive if the resource had been deleted [1]. This approach doesn't work if the get-resource script isn't used to get the snapshot. This commit modifies the one instance where this happens to use the get-resource script, ensuring that the kubearchive fallback is used. [1] konflux-ci/release-service-utils#657 Assisted-by: Cursor Signed-off-by: Lubomir Gallovic <lgallovi@redhat.com>
querti
added a commit
to querti/release-service-catalog
that referenced
this pull request
Feb 17, 2026
The catalog tasks mostly use the get-resource script in release-utils-repo to get Kubernetes resources. For snapshots, this script has been modified to fallback to kubearchive if the resource had been deleted [1]. This approach doesn't work if the get-resource script isn't used to get the snapshot. This commit modifies the one instance where this happens to use the get-resource script, ensuring that the kubearchive fallback is used. [1] konflux-ci/release-service-utils#657 Assisted-by: Cursor Signed-off-by: Lubomir Gallovic <lgallovi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the get-resource script to fallback to kubearchive if the resource is deleted. This functionality is restricted to snapshots since I don't know the side effects if it was enabled for every resource. But theoretically it can be enabled for other resources as well.
Kubearchive needs to be configured before it can be used. The script performs the configuration - it is semi-automatic, the resources are gathered from kubectl config + cluster by the interactive script. Temporary kubearchive config file is used (in the /tmp dir) so that the script would work in container/kubernetes environment and so that it wouldn't interfere with the hosts environment.
The script allows jsonpath, but this is not supported by kubearchive. To simulate the functionality, jq is used for kubearchive. jq is different from kubernetes jsonpath, so some substitutions had to be used. It will work for the common cases (the ones found in release-service catalog), but it may break if a more complex expression is used.
Assisted-by: Cursor