Open
Conversation
SlavikGh0st
reviewed
Jan 22, 2025
| Direction.Right => Direction.Down, | ||
| Direction.Down => Direction.Left, | ||
| Direction.Left => Direction.Up, | ||
| _ => throw new ArgumentOutOfRangeException(nameof(direction), direction, null) |
There was a problem hiding this comment.
Вместо исключений всюду в программе используй паттерн Result
SlavikGh0st
reviewed
Jan 22, 2025
| Direction.Right => new Size(Step, 0), | ||
| Direction.Down => new Size(0, -Step), | ||
| Direction.Left => new Size(-Step, 0), | ||
| _ => throw new ArgumentOutOfRangeException(nameof(direction)) |
There was a problem hiding this comment.
Вместо исключений всюду в программе используй паттерн Result
SlavikGh0st
reviewed
Jan 22, 2025
| { | ||
| return Result.Fail<IEnumerable<string>>($"Access to the file is denied: {filePath}"); | ||
| } | ||
| catch (IOException ex) |
There was a problem hiding this comment.
Тут можно, наверн, чуть ли не любую ошибку ловить, чтобы наверняка
SlavikGh0st
reviewed
Jan 22, 2025
| public static void SaveImage(Bitmap bmp, string fileName, string imageFormat) | ||
| { | ||
| fileName = $"{fileName}.{imageFormat.ToLower()}"; | ||
| bmp.Save(fileName); |
There was a problem hiding this comment.
Как будто тут у нас вполне может что-то стрельнуть, нет?
SlavikGh0st
reviewed
Jan 22, 2025
| .Returns(Rectangle); | ||
| A.CallTo(() => cloudLayouter.PutNextRectangle(new Size(500, 100))) | ||
| .Returns(Rectangle); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SlavikGh0st