Open
Conversation
Yaroslav332
suggested changes
Oct 28, 2025
Testing/Basic/Homework/2. NumberValidator/NumberValidatorTests.cs
Outdated
Show resolved
Hide resolved
Yaroslav332
suggested changes
Oct 29, 2025
| private static Person person0ParentsLimitsCopy = Person.Copy(person0ParentsLimits); | ||
| private static Person person1Parents = new Person("1", 1, 1, 1, new Person("2", 2, 2, 2, null)); | ||
| private static Person person1ParentsСopy = new Person("1", 1, 1, 1, new Person("2", 2, 2, 2, null)); | ||
| private static Person person1ParentsСopy = Person.Copy(person1Parents); |
There was a problem hiding this comment.
Это просто заметка по кодстайлу, в разных коммандах разное бывает принято, но давай сделаем вот так:
Хорошо, что добавил копирование, но тогда лучше добавь в Person, что-то типа такого
public Person Copy() => Copy(this)!;
И явно указать, что родитель nullable: Person? parent
Так не будет показывать варнингов из-за null ссылок. И соответственно замени все Person.Copy(p) на p.Copy()
| actual.Should().BeEquivalentTo(expected, options => | ||
| options | ||
| .Excluding(t => t.Id) | ||
| .Using<Person>(ctx => |
There was a problem hiding this comment.
Тут я имел ввиду использовать options .Excluding(t => t.Path.EndsWith("Id")). FluentAssertions умеет создавать путь у свойств так что все вложенные Id будут выглядеть типа person.Id, person.Parent.Id, person.Parent.Parent.Id и т.д.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Наставник @InTheNameOfYarik