Голубев Владимир

Testing/Basic/Basic.csproj

@@ -11,7 +11,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="FluentAssertions" Version="6.12.0" />
+    <PackageReference Include="FluentAssertions" Version="8.8.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
     <PackageReference Include="NUnit" Version="4.1.0" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />

Testing/Basic/Homework/1. ObjectComparison/City.cs

@@ -0,0 +1,3 @@
+namespace Basic.Homework._1._ObjectComparison;
+
+public record City(int Id, string Name);

Testing/Basic/Homework/1. ObjectComparison/Person.cs

@@ -1,4 +1,6 @@
-namespace HomeExercise.Tasks.ObjectComparison;
+using Basic.Homework._1._ObjectComparison;
+
+namespace HomeExercise.Tasks.ObjectComparison;
 
 
 public class Person
@@ -8,14 +10,16 @@ public class Person
     public string Name;
     public Person Parent;
     public int Id;
+    public City City;
 
-    public Person(string name, int age, int height, int weight, Person parent)
+    public Person(string name, int age, int height, int weight, Person parent, City city)
     {
         Id = IdCounter++;
         Name = name;
         Age = age;
         Height = height;
         Weight = weight;
         Parent = parent;
+        City = city;
     }
 }

Testing/Basic/Homework/1. ObjectComparison/TsarEqualityComparer.cs

@@ -0,0 +1,15 @@
+using FluentAssertions;
+using HomeExercise.Tasks.ObjectComparison;
+
+namespace Basic.Homework._1._ObjectComparison;
+
+public static class TsarEqualityComparer
+{
+    public static void CheckTsarEquality(Person actualTsar, Person expectedTsar)
+    {
+        actualTsar.Should().BeEquivalentTo(expectedTsar, o => o
+            .Excluding(m => m.Name.Equals(nameof(Person.Id)) && m.DeclaringType == typeof(Person))
+            .IgnoringCyclicReferences()
+            .AllowingInfiniteRecursion());
+    }
+}

Testing/Basic/Homework/1. ObjectComparison/TsarRegistry.cs

@@ -1,11 +1,56 @@
-namespace HomeExercise.Tasks.ObjectComparison;
+using Basic.Homework._1._ObjectComparison;
+
+namespace HomeExercise.Tasks.ObjectComparison;
 
 public class TsarRegistry
 {
     public static Person GetCurrentTsar()
     {
         return new Person(
             "Ivan IV The Terrible", 54, 170, 70,
-            new Person("Vasili III of Russia", 28, 170, 60, null));
+            new Person("Vasili III of Russia", 28, 170, 60, null, new City(1, "Peterburg")),
+            new City(1, "Peterburg"));
+    }
+
+    public static Person GetCurrentTsarWithCyclicDependency()
+    {
+        var tsar = new Person("Ivan IV The Terrible", 54, 170, 70, null, new City(1, "Peterburg"));
+        var parent = new Person("Vasili III of Russia", 28, 170, 60, tsar, new City(1, "Peterburg")); 
+        tsar.Parent = parent;
+
+        return tsar;
+    }
+
+    public static Person GetCurrentTsarWithAncestryChain(int generations)
+    {
+        Person current = null!;
+
+        for (int i = generations; i > 0; i--)
+        {
+            current = new Person($"Ancestor {i}", 40 + i * 5, 170 + i, 65 + i, current, new City(1, "Peterburg"));
+        }
+
+        var tsar = new Person("Ivan IV The Terrible", 54, 170, 70, current, new City(1, "Peterburg"));
+
+        return tsar;
+    }
+
+    public static Person GetTsarWithWrongAncestor(int generations, int wrongAncestorLevel)
+    {
+        Person current = null!;
+
+        for (int i = generations; i > 0; i--)
+        {
+            current = new Person($"Ancestor {i}", 40 + i * 5, 170 + i, 65 + i, current, new City(1, "Peterburg"));
+
+            if (i == wrongAncestorLevel)
+            {
+                current.Name = "Imposter";
+            }
+        }
+
+        var tsar = new Person("Ivan IV The Terrible", 54, 170, 70, current, new City(1, "Peterburg"));
+
+        return tsar;
     }
 }

Testing/Basic/Homework/1. ObjectComparison/TsarTests.cs

@@ -0,0 +1,115 @@
+using Basic.Homework._1._ObjectComparison;
+using FluentAssertions;
+using HomeExercise.Tasks.ObjectComparison;
+using NUnit.Framework;
+
+namespace HomeExercise.Tasks.TsarTests;
+
+public class TsarTests
+{
+    [Test]
+    public void CheckTsarEquality_WithValidTsar_ShouldNotThrow()
+    {
+        var actualTsar = TsarRegistry.GetCurrentTsar();
+        var expectedTsar = new Person("Ivan IV The Terrible", 54, 170, 70,
+            new Person("Vasili III of Russia", 28, 170, 60, null, new City(1, "Peterburg")),
+            new City(1, "Peterburg"));
+
+        var act = () => TsarEqualityComparer.CheckTsarEquality(actualTsar, expectedTsar);
+
+        act.Should().NotThrow();
+    }
+
+    [Test]
+    public void CheckTsarEquality_WithCyclicDependency_ShouldNotThrow()
+    {
+        var actualTsar = TsarRegistry.GetCurrentTsarWithCyclicDependency();
+
+        var expectedTsar =
+            new Person("Ivan IV The Terrible", 54, 170, 70, null, new City(1, "Peterburg"));
+        var expectedParent =
+            new Person("Vasili III of Russia", 28, 170, 60, expectedTsar, new City(1, "Peterburg"));
+        expectedTsar.Parent = expectedParent;
+
+        var act = () => TsarEqualityComparer.CheckTsarEquality(actualTsar, expectedTsar);
+
+        act.Should().NotThrow();
+    }
+
+    [Test]
+    public void CheckTsarEquality_WithParentNullInOneObject_ShouldThrow()
+    {
+        var actualTsar = TsarRegistry.GetCurrentTsar();
+        var expectedTsar =
+            new Person("Ivan IV The Terrible", 54, 170, 70, null, new City(1, "Peterburg"));
+
+        var act = () => TsarEqualityComparer.CheckTsarEquality(actualTsar, expectedTsar);
+
+        act.Should().Throw<AssertionException>();
+    }
+
+    [Test]
+    public void CheckTsarEquality_WithDifferentChainLength_ShouldThrow()
+    {
+        var actualTsar = TsarRegistry.GetCurrentTsarWithAncestryChain(5);
+        var expectedTsar = TsarRegistry.GetCurrentTsarWithAncestryChain(3);
+
+        var act = () => TsarEqualityComparer.CheckTsarEquality(actualTsar, expectedTsar);
+
+        act.Should().Throw<AssertionException>();
+    }
+
+
+    [TestCase(5, 3, TestName = "WrongAncestorInMiddleOfChain")]
+    [TestCase(5, 1, TestName = "WrongAncestorAtStartOfChain")]
+    [TestCase(5, 5, TestName = "WrongAncestorAtEndOfChain")]
+    [TestCase(100, 50, TestName = "WrongAncestorLongChain")]
+    public void CheckTsarEquality_WithWrongAncestorInChain_ShouldThrow(int generations, int wrongAncestorLevel)
+    {
+        var actualTsar = TsarRegistry.GetCurrentTsarWithAncestryChain(generations);
+        var expectedTsar = TsarRegistry.GetTsarWithWrongAncestor(generations, wrongAncestorLevel);
+
+        var act = () => TsarEqualityComparer.CheckTsarEquality(actualTsar, expectedTsar);
+
+        act.Should().Throw<AssertionException>();
+    }
+
+    [Test]
+    public void CheckTsarEquality_WithDifferentCityIds_ShouldThrow()
+    {
+        var actualTsar = TsarRegistry.GetCurrentTsar();
+        var expectedTsar = new Person("Ivan IV The Terrible", 54, 170, 70,
+            new Person("Vasili III of Russia", 28, 170, 60, null, new City(2, "Peterburg")),
+            new City(1, "Peterburg"));
+
+        var act = () => TsarEqualityComparer.CheckTsarEquality(actualTsar, expectedTsar);
+
+        act.Should().Throw<AssertionException>();
+    }
+
+    [Test]
+    public void CheckTsarEquality_WithDifferentIds_ShouldThrow()
+    {
+        var actualTsar = TsarRegistry.GetCurrentTsar();
+
+        var expectedTsar = TsarRegistry.GetCurrentTsar();
+        expectedTsar.Id = 2;
+        expectedTsar.City = new City(2, "Peterburg");
+
+        var act = () => TsarEqualityComparer.CheckTsarEquality(actualTsar, expectedTsar);
+
+        act.Should().Throw<AssertionException>();
+    }
+
+}
+
+/*
+ * Что хорошо в решении:
+ * 1.) Тест легче читать: 3 строчки vs найти метод, залезть в него и посмотреть: а что он там делает
+ * 2.) Явно указываем, какие поля мы исключаем из проверки
+ * 3.) При добавлении новых полей в Person нужно провести минимальный рефакторинг(исключить из проверки
+ *     или вообще ничего не трогать)
+ * 4.) Падаем с адекватной информацией об ошибке, в отличие от просто непонятного False
+ * 5.) Проверяем всю династию(не только родителя)
+ * 6.) Прошлое решение падало при циклической зависимости(StackOverflow), мое решение корректно обрабатывает этот случай
+ */

Testing/Basic/Homework/2. NumberValidator/NumberValidator.cs

@@ -4,7 +4,9 @@ namespace HomeExercise.Tasks.NumberValidator;
 
 public class NumberValidator
 {
-    private readonly Regex numberRegex;
+    private static readonly Regex NumberRegex = 
+        new Regex(@"^([+-]?)(\d+)([.,](\d+))?$", RegexOptions.Compiled);
+
     private readonly bool onlyPositive;
     private readonly int precision;
     private readonly int scale;
@@ -17,8 +19,7 @@ public NumberValidator(int precision, int scale = 0, bool onlyPositive = false)
         if (precision <= 0)
             throw new ArgumentException("precision must be a positive number");
         if (scale < 0 || scale >= precision)
-            throw new ArgumentException("precision must be a non-negative number less or equal than precision");
-        numberRegex = new Regex(@"^([+-]?)(\d+)([.,](\d+))?$", RegexOptions.IgnoreCase);
+            throw new ArgumentException("scale must be a non-negative number less than precision");
     }
 
     public bool IsValidNumber(string value)
@@ -32,7 +33,7 @@ public bool IsValidNumber(string value)
         if (string.IsNullOrEmpty(value))
             return false;
 
-        var match = numberRegex.Match(value);
+        var match = NumberRegex.Match(value);
         if (!match.Success)
             return false;