Revert "feat(search): 22291 select area when location chosen (#1194)"#1248
Merged
Revert "feat(search): 22291 select area when location chosen (#1194)"#1248
Conversation
This reverts commit 16eee94.
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughRemoved the search-hover highlighting feature and its map layer. Deleted related atom, constants, renderer, layer initializer, and documentation. Stripped highlight side effects from SearchBar and search atoms. Search now skips geometry highlighting and focus-on-geometry; selection updates bbox only. Initialization of the highlight layer was removed from Search index. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant SB as SearchBar (UI)
participant SA as searchAtoms
participant HGA as searchHighlightedGeometryAtom
participant L as initSearchHighlightLayer
participant R as SearchHighlightRenderer
participant M as Map
rect rgb(235, 245, 255)
note over U,SB: Previous flow (with hover highlight)
U->>SB: Hover result
SB->>HGA: Set hovered geometry
opt Layer initialized
L->>R: Mount renderer with GeoJSON source
HGA-->>R: Subscription update (geometry)
R->>M: Update layer source (highlight)
end
U->>SB: Select result
SB->>SA: itemSelectAction
SA->>M: Update view (focus/bbox)
end
sequenceDiagram
autonumber
participant U as User
participant SB as SearchBar (UI)
participant SA as searchAtoms
participant M as Map
rect rgb(240, 255, 240)
note over U,SB: New flow (highlight removed)
U->>SB: Hover result
note over SB: No highlight side effects
U->>SB: Select result
SB->>SA: itemSelectAction
SA->>M: Update bbox only
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (9)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Bundle size diff
|
|
Preview environments for this PR:
These previews are automatically updated with each commit. Note: After a new deployment, it may take a few minutes for the changes to propagate and for caches to update. During this time, you might experience temporary loading issues or see an older version of the app. If the app fails to load, please wait a few minutes and try again. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1248 +/- ##
==========================================
+ Coverage 12.32% 12.36% +0.04%
==========================================
Files 728 724 -4
Lines 29952 29838 -114
Branches 1404 1400 -4
==========================================
- Hits 3691 3690 -1
+ Misses 25704 25594 -110
+ Partials 557 554 -3
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 16eee94.
Summary by CodeRabbit
Refactor
Documentation
Chores