feat: allow useImage() args to be any reactive value#258
Merged
lavrton merged 2 commits intokonvajs:masterfrom Jul 14, 2025
Merged
feat: allow useImage() args to be any reactive value#258lavrton merged 2 commits intokonvajs:masterfrom
lavrton merged 2 commits intokonvajs:masterfrom
Conversation
Contributor
Author
|
This is a little out of topic for this PR, but I had to update |
Member
|
Thanks. Released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, Vue has a more flexible approach to managing reactivity on composables with
MaybeRefOrGettertypes. Previously, withstring | Ref<string>,computedor simple getter variables would not be allowed as TypeScript values ofuseImage(even though they would work astypeofwould fail the string check).On the code side, this allows:
There's a little perf upgrade of packaging all watchable values into one computed instead of creating up to 3 refs!
Happy to address any concerns about it :)