🐛 Fix 500 on get bundle with target without a ruleSet. (#1010)

closes #1009

This only affects the API user. The UI won't create a custom target
without a ruleSet.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Avoided a crash when processing profiles that include targets without
associated rule sets by skipping those targets.

* **Tests**
* Added end-to-end tests for analysis profiles: seeding files, creating
profiles with mixed targets, and verifying profile bundle creation and
retrieval.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jeff Ortel <jortel@redhat.com>

Author: jortel

internal/api/profile.go

@@ -406,6 +406,9 @@ func (b *ApBundle) addTargets(m *model.AnalysisProfile) (err error) {
 		if target.Builtin() {
 			continue
 		}
+		if target.RuleSet == nil {
+			continue
+		}
 		err = b.addRuleSet(target.RuleSet)
 		if err != nil {
 			return

test/binding/profile_test.go

@@ -2,6 +2,7 @@ package binding
 
 import (
 	"errors"
+	"os"
 	"testing"
 
 	"github.com/konveyor/tackle2-hub/shared/api"
@@ -12,17 +13,57 @@ import (
 func TestAnalysisProfile(t *testing.T) {
 	g := NewGomegaWithT(t)
 
+	// Grab seeded files.
+	files, err := client.File.List()
+	g.Expect(err).To(BeNil())
+	g.Expect(len(files)).To(BeNumerically(">", 0))
+
 	// Create an identity for the profile to reference
 	identity := &api.Identity{
 		Name: "test-identity",
 		Kind: "Test",
 	}
-	err := client.Identity.Create(identity)
+	err = client.Identity.Create(identity)
 	g.Expect(err).To(BeNil())
 	t.Cleanup(func() {
 		_ = client.Identity.Delete(identity.ID)
 	})
 
+	// Create a custom target with ruleSet.
+	targetA := &api.Target{
+		Name:  "test-target-a",
+		Image: api.Ref{ID: files[0].ID},
+		RuleSet: &api.RuleSet{
+			Rules: []api.Rule{
+				{
+					Name: "test-rule-1",
+					File: &api.Ref{ID: files[0].ID},
+				},
+				{
+					Name: "test-rule-2",
+				},
+			},
+		},
+	}
+	err = client.Target.Create(targetA)
+	g.Expect(err).To(BeNil())
+	g.Expect(targetA.ID).NotTo(BeZero())
+	t.Cleanup(func() {
+		_ = client.Target.Delete(targetA.ID)
+	})
+
+	// Create a custom target without ruleSet.
+	targetB := &api.Target{
+		Name:  "test-target-no-ruleset",
+		Image: api.Ref{ID: files[0].ID},
+	}
+	err = client.Target.Create(targetB)
+	g.Expect(err).To(BeNil())
+	g.Expect(targetB.ID).NotTo(BeZero())
+	t.Cleanup(func() {
+		_ = client.Target.Delete(targetB.ID)
+	})
+
 	// Define the profile to create
 	profile := &api.AnalysisProfile{
 		Name:        "Test Profile",
@@ -48,11 +89,13 @@ func TestAnalysisProfile(t *testing.T) {
 			},
 			Repository: &api.Repository{
 				URL:  "https://github.com/konveyor/rulesets.git",
-				Path: "default/generated/camel3",
+				Path: "stable/java/camel3",
 			},
 			Targets: []api.ApTargetRef{
 				{ID: 2, Name: "Containerization"},
 				{ID: 6, Name: "OpenJDK", Selection: "konveyor.io/target=openjdk17"},
+				{ID: targetA.ID, Name: targetA.Name},
+				{ID: targetB.ID, Name: targetB.Name},
 			},
 		},
 	}
@@ -100,6 +143,19 @@ func TestAnalysisProfile(t *testing.T) {
 	eq, report = cmp.Eq(profile, updated, "UpdateUser")
 	g.Expect(eq).To(BeTrue(), report)
 
+	// GET: bundle.
+	f, err := os.CreateTemp("", "bundle-*.tar")
+	g.Expect(err).To(BeNil())
+	defer func() {
+		_ = os.Remove(f.Name())
+	}()
+	_ = f.Close()
+	err = client.AnalysisProfile.GetBundle(profile.ID, f.Name())
+	g.Expect(err).To(BeNil())
+	st, err := os.Stat(f.Name())
+	g.Expect(err).To(BeNil())
+	g.Expect(st.Size()).NotTo(BeZero())
+
 	// DELETE: Remove the profile
 	err = client.AnalysisProfile.Delete(profile.ID)
 	g.Expect(err).To(BeNil())