test: comprehensive v0.8 API coverage (250 tests) - so we can copy these to main later and know what broke. #154
Open
lilith wants to merge 2 commits intokornelski:v0.8from
Open
test: comprehensive v0.8 API coverage (250 tests) - so we can copy these to main later and know what broke. #154lilith wants to merge 2 commits intokornelski:v0.8from
lilith wants to merge 2 commits intokornelski:v0.8from
Conversation
Exercises the entire v0.8 public API surface: - All pixel types (RGB, BGR, GRB, RGBA, BGRA, ARGB, ABGR, Gray, GrayAlpha, GrayA) - All traits (ComponentMap, ColorComponentMap, ComponentSlice, ComponentBytes, AsPixels, FromSlice) - All inherent methods (new, value, with_alpha, map_alpha, map_gray, rgb, bgr, iter, etc.) - All From/Into conversions (layout reordering, type widening, gray-to-rgb, array, tuple) - All operator impls (Add, Sub, Mul, Div, and Assign variants, Sum) - All formatting (Display, UpperHex, LowerHex) - Derive impls (Clone, Copy, Debug, Default, Eq, PartialOrd, Hash) - Feature-gated: as-bytes, bytemuck, serde, checked_fns - AsRef/AsMut impls - Memory layout verification
With unstable-experimental, Gray becomes Gray_v09 and GrayAlpha becomes GrayA. These named-struct types lack many trait impls that the v08 tuple structs have (ComponentMap, ComponentSlice, ComponentBytes, AsRef, AsMut, arithmetic ops, Sum, bytemuck Pod). Gate all affected tests so the suite passes with --all-features. 252 tests without unstable-experimental, 206 with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercises the entire v0.8 public API surface:
Preliminary discoveries vs main:
u16 components now get 4-digit padding