fix: add input validation and CLI consistency across all nodes#6
Merged
fix: add input validation and CLI consistency across all nodes#6
Conversation
Audit all nodes against CLAUDE.md checklist and fix compliance gaps:
- system-telemetry: add topic name validation and rate_hz bounds checking
- network-monitor: add topic/numeric validation, endpoint default, build task
- openmeteo: add config bounds validation, fix Header scope field, scope
topics with bubbaloop/{scope}/{machine}/ prefix, rename -z to -e flag,
add HTTP client timeout
- inference: add -c/-e CLI flags, config.yaml, scoped subscribe topic
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rate_hzbounds checking (0.01–1000.0)-eendpoint default totcp/127.0.0.1:7447, addbuildtask alias in pixi.tomlFetchConfigbounds validation, populatescopefield in all Header messages, scope data topics withbubbaloop/{scope}/{machine}/prefix, rename-zflag to-efor consistency, add 30s HTTP client timeout-c/-eCLI flags viaargh, addconfig.yamlwithsubscribe_topic, use scoped subscribe topic, validate topic patternAll changes modeled after rtsp-camera which was already fully compliant.
Test plan
system-telemetry: verify node rejects invalidpublish_topicand out-of-rangerate_hznetwork-monitor: verify validation errors on bad config, confirm-edefault worksopenmeteo: verify config bounds rejection, confirm weather topics now appear underbubbaloop/{scope}/{machine}/weather/*, confirm-eflag works (was-z)inference: verify-c config.yamland-eflags work, confirm subscription uses scoped topic🤖 Generated with Claude Code