fix: replace unwrap() with safe handling in tensor Display impl#802
Open
VedantMadane wants to merge 1 commit intokornia:mainfrom
Open
fix: replace unwrap() with safe handling in tensor Display impl#802VedantMadane wants to merge 1 commit intokornia:mainfrom
VedantMadane wants to merge 1 commit intokornia:mainfrom
Conversation
- Use unwrap_or(0) for empty iterator in max() to avoid panic on empty tensors
- Use ok_or(std::fmt::Error)? for split_once('e') to propagate errors properly
Fixes kornia#801
VedantMadane
force-pushed
the
fix/tensor-unwrap-safety
branch
from
9bde56b to
d7de3ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #801
Summary
Replaces two
unwrap()calls in the Display trait implementation for Tensor with safe error handling, per project guidelines in AGENTS.md and CONTRIBUTING.md.Changes
.max().unwrap()→.max().unwrap_or(0)— safely handles empty tensors without panickingsplit_once('e').unwrap()→split_once('e').ok_or(std::fmt::Error)?— propagates errors viafmt::Resultinstead of panicking