-
Notifications
You must be signed in to change notification settings - Fork 204
feat-add-reactions #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-add-reactions #141
Conversation
|
Hi @xav-ie, thanks for the PR! There is somehow a demand for this feature, so that's why I come here across. Could you please confirm that this functionality works on all three types of tokes? |
|
I'd appreciate that before we merge @xav-ie or @ZihaoZhou will do one more test with |
|
Yes ok. That is reasonable. It would be cool to fully automate the testing. Like have a ci and functions to test things. I might make one after I verify this works with xoxb.... verifying all three for api changes is quite a bit of work. |
|
@xav-ie please have a look an existing implementation of integration tests i.e. how MCP server is bootstrapped, tools registered and how we verify that using real OpenAI API this MCP is truly working https://github.com/korotovsky/slack-mcp-server/blob/master/pkg/handler/channels_test.go#L31. I might need then to add a new |
✅ Tested with
|
| Emoji | Result |
|---|---|
:rocket: |
✅ Success |
:tada: |
✅ Success |
:white_check_mark: |
✅ Success |
MCP Response Examples
{"result": {"content": [{"type": "text", "text": "Successfully added :rocket: reaction to message 1769718633.771359 in channel C0ABNAGCV19"}]}}
{"result": {"content": [{"type": "text", "text": "Successfully added :tada: reaction to message 1769718633.771359 in channel C0ABNAGCV19"}]}}
{"result": {"content": [{"type": "text", "text": "Successfully added :white_check_mark: reaction to message 1769718633.771359 in channel C0ABNAGCV19"}]}}Slack Verification
Verified reactions appear correctly in Slack UI:
This completes testing for all three token types:
-
xoxc+xoxd(browser tokens) - tested by @xav-ie -
xoxp(user token) - tested by @xav-ie -
xoxb(bot token) - tested here ✅
Ready to merge! 🚀
|
This is the way to go! 🚀 Thank you @Flare576! Thank you @ZihaoZhou for testing |
Companion to reactions_add (merged in korotovsky#141). Allows removing emoji reactions from messages using the same channel/timestamp/emoji params. Tested with xoxb, xoxc/xoxd token types.
Companion to reactions_add (merged in korotovsky#141). Allows removing emoji reactions from messages using the same channel/timestamp/emoji params. Tested with xoxb, xoxc/xoxd token types.


You can now add emoji reaction through MCP 👍
I consider emoji as a message, so I leverage the existing env var. Please let me know if I should have instead created a new one.