fix: correct channel allowlist/blocklist logic in isChannelAllowedForConfig#189
Merged
korotovsky merged 1 commit intokorotovsky:masterfrom Feb 6, 2026
Merged
Conversation
The isChannelAllowedForConfig() function had inverted return logic. When a channel was NOT found in the list, it returned the opposite of what was intended: - Allowlist mode incorrectly allowed unlisted channels - Blocklist mode incorrectly blocked unlisted channels Fixed by changing 'return !isNegated' to 'return isNegated'. Added unit tests for isChannelAllowedForConfig(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isChannelAllowedForConfig()Resolves #138
Expected Behavior (per README)
From README.md, Environment Variables section:
This means:
C123,C456(allowlist) → only C123 and C456 are allowed, others blocked!C123,!C456(blocklist) → all channels allowed except C123 and C456Root Cause
Line 620 returned
!isNegatedinstead ofisNegatedwhen no match was found in the channel list, inverting the intended behavior.Changes
pkg/handler/conversations.go:620isChannelAllowedForConfig()Test plan