fix: serialize getting message types to avoid slack rate limits#97
Merged
korotovsky merged 1 commit intokorotovsky:masterfrom Sep 22, 2025
Merged
fix: serialize getting message types to avoid slack rate limits#97korotovsky merged 1 commit intokorotovsky:masterfrom
korotovsky merged 1 commit intokorotovsky:masterfrom
Conversation
korotovsky
reviewed
Sep 12, 2025
| } | ||
|
|
||
| var chans []Channel | ||
| for _, t := range AllChanTypes { |
Owner
There was a problem hiding this comment.
Should not this line be range channelTypes {?
Contributor
Author
There was a problem hiding this comment.
I also asked myself, but I left it as it was: https://github.com/korotovsky/slack-mcp-server/blob/master/pkg/provider/api.go#L558
Owner
There was a problem hiding this comment.
Yeah... I can explain how it happened and you might improve it in this PR? Basically background goroutine must fetch all channels of all types no matter what to provide consistent cache, before cache was introduced this function getChannels() have been used directly from tool handler with parameter channel types provided from the user.
redaphid
pushed a commit
to redaphid/slack-mcp-server
that referenced
this pull request
Nov 24, 2025
fix: serialize getting message types to avoid slack rate limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
It serializes the calls for each of slack message types.
Now the limit of GetConversationsParameters is respected (otherwise, if we requested all messages from slack, each call would have maximum 10 entries (see #31 (comment) for more details)