Merged
Conversation
This will allow us to do more than just bundling.
This was previously done by ncc but esbuild can't do it out of the box. This simple script does pretty much the same as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the packaging process to use a new
esbuild.config.mjsscript instead of a long CLI command. The new script not only bundles the application but also automatically collects and outputs license information for all bundled dependencies. This was necessary because the license information could not be updated automatically since #555.Packaging process improvements:
esbuild.config.mjsscript that bundles the application and generates adist/licenses.txtfile containing license details for all bundlednode_modulespackages.packagescript inpackage.jsonto use the newesbuild.config.mjsscript instead of the previous inline esbuild CLI command.