Skip to content

Fix syntax of several Dana programs#73

Merged
kostis merged 14 commits intokostis:masterfrom
orestis42:master
Apr 22, 2025
Merged

Fix syntax of several Dana programs#73
kostis merged 14 commits intokostis:masterfrom
orestis42:master

Conversation

@orestis42
Copy link
Contributor

@orestis42 orestis42 commented Apr 19, 2025

Fixed various lexical and syntax errors found in the programs.

orestis42 and others added 7 commits April 10, 2025 19:12
Use"=" instead of "==" for equality and moved "var temp is int"
declaration to the beginning of the block. The program still contains a
semantic error so I copied it to the dana/programs-erroneous directory.
Adjusted the bAdded a missing comma in a procedure call, changed
function calls to use () instead of :, specifed a fixed size for the
local array variable declaration, and corrected the assignment operator
from "=" to ":=".
Add actual semantic error in powint-erroneous.dana and highlighted it
with a comment.
Fixed various lexical and syntax errors found in the program.
The nested dot_product function definition was moved before the main
execution statements within main. The equality comparison was changed
from == to =. The begin/end keywords were removed from the bodies of
main and dot_product because they contained declarations, requiring
layout-based blocks instead. Finally, the call dot_product : ... was
changed to dot_product(...) to use the correct function call syntax
within an expression.
Use "=" instead of "=="
@orestis42 orestis42 changed the title Fix syntax of calculator.dana Fix syntax of several Dana programs Apr 19, 2025
Variable declarations for a and b were moved from inside the else block
to the beginning of the fib function's body.
The 'var s' declaration was moved to the start of gcd, the else block's
begin/end was removed, the equality operator was changed from == to =,
and function calls were updated to use parenthesis () syntax.
The colon after main was removed, assignment operators were changed from
'=' to ':=', 'return n' became 'return : n', parameter types were
defined using 'as' instead of 'is', and the final 'writeString' call was
corrected.
@kostis
Copy link
Owner

kostis commented Apr 22, 2025

Thanks for your contribution (and for all these fixes)!

Although some removals of begin ... end blocks are questionable, because they may have been there for compilers that do not handle the off-side rule of Dana, I will go ahead and merge this.

@kostis kostis merged commit a20fc3a into kostis:master Apr 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants