Fix semantics of binarysearch.dana#74
Merged
kostis merged 16 commits intokostis:masterfrom Apr 22, 2025
Merged
Conversation
Use"=" instead of "==" for equality and moved "var temp is int" declaration to the beginning of the block. The program still contains a semantic error so I copied it to the dana/programs-erroneous directory.
Adjusted the bAdded a missing comma in a procedure call, changed function calls to use () instead of :, specifed a fixed size for the local array variable declaration, and corrected the assignment operator from "=" to ":=".
Add actual semantic error in powint-erroneous.dana and highlighted it with a comment.
Fixed various lexical and syntax errors found in the program.
The nested dot_product function definition was moved before the main execution statements within main. The equality comparison was changed from == to =. The begin/end keywords were removed from the bodies of main and dot_product because they contained declarations, requiring layout-based blocks instead. Finally, the call dot_product : ... was changed to dot_product(...) to use the correct function call syntax within an expression.
Use "=" instead of "=="
Variable declarations for a and b were moved from inside the else block to the beginning of the fib function's body.
The 'var s' declaration was moved to the start of gcd, the else block's begin/end was removed, the equality operator was changed from == to =, and function calls were updated to use parenthesis () syntax.
The colon after main was removed, assignment operators were changed from '=' to ':=', 'return n' became 'return : n', parameter types were defined using 'as' instead of 'is', and the final 'writeString' call was corrected.
Added return types to the declerations of 'partition' and 'binarySearch' function definitions. Corrected a type mismatch in the array population loop by changing the termination assignment from the byte literal '\0' to the integer 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added return types to the declarations of
partitionandbinarySearchfunction definitions. Corrected a type mismatch in the array population loop by changing the termination assignment from the byte literal'\0'to the integer0.