Fix EOF handling in calculator.dana main loop#81
Merged
kostis merged 1 commit intokostis:masterfrom Aug 11, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a single line at the start of the lines loop in
calculator.dana:This ensures the buffer is always null-terminated before reading new input.
When readString reaches EOF without writing anything, strlen(buf) now returns 0 instead of reading stale data from previous iterations.
Why it was necessary:
Without clearing the buffer, when having an input file for ./a.out < calculator.input the loop would be infinite. This fix guarantees that the loop terminates cleanly at EOF.