Set universal CMP0167 cmake policy to fix nix build break.#3
Open
guylamar2006 wants to merge 1 commit intokotatogram:masterfrom
Open
Set universal CMP0167 cmake policy to fix nix build break.#3guylamar2006 wants to merge 1 commit intokotatogram:masterfrom
guylamar2006 wants to merge 1 commit intokotatogram:masterfrom
Conversation
Contributor
|
Can you explain why is this needed? |
Contributor
|
also, policies are applied here |
Contributor
|
But looking at its description I'm not sure there's any sense to set it when you can just add CONFIG argument to find_package? |
Contributor
|
Or maybe even do like OpenAL (try both module and config) cmake_helpers/external/openal/CMakeLists.txt Lines 11 to 20 in b5d7cc3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.