feat: add support for global --content-appearance default#735
Open
birjj wants to merge 1 commit intokovetskiy:masterfrom
Open
feat: add support for global --content-appearance default#735birjj wants to merge 1 commit intokovetskiy:masterfrom
--content-appearance default#735birjj wants to merge 1 commit intokovetskiy:masterfrom
Conversation
birjj
changed the title
--content-appearance override--content-appearance default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a
--content-appearanceflag to the CLI, which can be used to globally set the<!-- Content-Appearance: ... -->value. Previously users would have to set the<!-- Content-Appearance: ... -->header in every single document that they wanted to not be full width. With this new flag they can set it globally.Implemented to be backwards compatible, so it still defaults to
full-widthif neither the flag nor a header is set. Headers within documents take precedence over the flag value, so individual documents can still be customized; the flag just sets the new default.Based on previous feedback in another PR I have chosen to throw an error if
--content-appearanceis set to anything other thanfixedorfull-width.