knode/validator: context logger w/ custom handlers; replaced log.Warn w/ log.Crit if sync fails#818
Open
knode/validator: context logger w/ custom handlers; replaced log.Warn w/ log.Crit if sync fails#818
Conversation
rgeraldes
changed the title
JekaMas
suggested changes
Oct 9, 2018
client/knode/validator/validator.go
Outdated
| txConfirmationTimeout = 10 * time.Second | ||
|
|
||
| // log handlers | ||
| fileHandler = log.Must.FileHandler("/var/log/validator_all.log", log.LogfmtFormat()) |
Contributor
There was a problem hiding this comment.
It can break non-unix clients or clients with no access to /var/log
Contributor
There was a problem hiding this comment.
agree, this needs to be configurable and passed down from main comand
jmatosp
reviewed
Oct 9, 2018
| func (val *validator) sync() { | ||
| if err := SyncWaiter(val.eventMux); err != nil { | ||
| log.Warn("Failed to sync with network", "err", err) | ||
| val.logger.Crit("Failed to sync with network", "err", err) |
Contributor
Author
There was a problem hiding this comment.
Because we can't start the validation without syncing
Contributor
There was a problem hiding this comment.
that doesn't mean we should kill the client, can we return nil or not starting vlidation process
Contributor
Author
There was a problem hiding this comment.
The current flow is a one shot type of thing and we will need to modify the flow to take that into account. I will open a separate issue for that problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #817