Add isMultiDay extension property and improve test naming conventions#13
Merged
Add isMultiDay extension property and improve test naming conventions#13
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 97.28% 97.30% +0.02%
==========================================
Files 15 15
Lines 2137 2153 +16
==========================================
+ Hits 2079 2095 +16
Misses 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds multi-day detection functionality to calendar components, enabling determination of whether events and todos span multiple calendar days. The implementation includes a shared helper function with comprehensive test coverage for various scenarios.
- Adds
isMultiDaygetter toEventComponentandTodoComponentextensions - Implements
_isMultiDayhelper function with logic for both all-day and timed components - Adds 14 new test cases covering edge cases for events and todos (duration-based, time-based, all-day scenarios)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/src/semantic/extensions/components.dart | Adds _isMultiDay helper function and isMultiDay getters to EventComponent and TodoComponent extensions with comprehensive documentation |
| test/semantic/extensions/components_test.dart | Adds comprehensive test coverage for isMultiDay functionality across different event and todo scenarios; modifies test description capitalization for timezone tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.