Skip to content

OSV metadata parsing issues #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpauljoseph wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSV metadata parsing issues #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/ingestor/parser/vuln/score.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ package vuln

import (
"strconv"
"strings"

"github.com/guacsec/guac/pkg/assembler/clients/generated"
attestation_vuln "github.com/guacsec/guac/pkg/certifier/attestation/vuln"
gocvss20 "github.com/pandatix/go-cvss/20"
gocvss30 "github.com/pandatix/go-cvss/30"
Expand All @@ -13,27 +13,27 @@ import (

func parseScoreBasedOnMethod(severity attestation_vuln.Severity) (float64, error) {
score := severity.Score
switch severity.Method {
switch {
// TODO: match for other score types
case string(generated.VulnerabilityScoreTypeCvssv2):
case strings.HasPrefix(score, "CVSS:2.0"):
vector, err := gocvss20.ParseVector(score)
if err != nil {
return 0, err
}
return vector.BaseScore(), nil
case string(generated.VulnerabilityScoreTypeCvssv3):
case strings.HasPrefix(score, "CVSS:3.0"):
vector, err := gocvss30.ParseVector(score)
if err != nil {
return 0, err
}
return vector.BaseScore(), nil
case string(generated.VulnerabilityScoreTypeCvssv31):
case strings.HasPrefix(score, "CVSS:3.1"):
vector, err := gocvss31.ParseVector(score)
if err != nil {
return 0, err
}
return vector.BaseScore(), nil
case string(generated.VulnerabilityScoreTypeCvssv4):
case strings.HasPrefix(score, "CVSS:4.0"):
vector, err := gocvss40.ParseVector(score)
if err != nil {
return 0, err
Expand Down
8 changes: 2 additions & 6 deletions pkg/ingestor/parser/vuln/vuln.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ package vuln

import (
"context"
"errors"
"fmt"
"strings"

Expand Down Expand Up @@ -153,11 +152,11 @@ func parseVulns(_ context.Context, s *attestation_vuln.VulnerabilityStatement) (
}
ivs = append(ivs, iv)

var severityErrors error
for _, severity := range res.Severity {
score, err := parseScoreBasedOnMethod(severity)
if err != nil {
severityErrors = errors.Join(fmt.Errorf("parsing severity score failed for method %s: %w", severity.Method, err))
// TODO: log it as Ward/Info log which severity failed to parse and why
continue
}
vmi = append(vmi, assembler.VulnMetadataIngest{
Vulnerability: vuln,
Expand All @@ -167,9 +166,6 @@ func parseVulns(_ context.Context, s *attestation_vuln.VulnerabilityStatement) (
},
})
}
if severityErrors != nil {
return nil, nil, nil, severityErrors
}
}
return vs, ivs, vmi, nil
}
Expand Down
Loading