-
Notifications
You must be signed in to change notification settings - Fork 1
A simple POC to change non KRM files to a structured k8s resource #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yuwenma
wants to merge
2
commits into
kptdev:main
Choose a base branch
from
yuwenma:poc-cm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| FROM ubuntu:20.04 | ||
|
|
||
| RUN apt-get update -y | ||
| RUN DEBIAN_FRONTEND=noninteractive apt-get install -y \ | ||
| python3 \ | ||
| python3-pip \ | ||
| python3-virtualenv \ | ||
| && update-alternatives --install /usr/bin/python python /usr/bin/python3 10 | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| RUN mkdir -p /src/code | ||
| RUN mkdir -p /app | ||
|
|
||
| COPY env-to-ini.py /src/code | ||
|
|
||
| CMD [ "python3", "/src/code/env-to-ini.py"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import os | ||
| import collections | ||
| import configparser | ||
| from os.path import exists | ||
|
|
||
| CM_PREFIX = "cm." | ||
| DELIMITER = "." | ||
| INI_FILE_NAME_ENV = "CM_INI_FILE_NAME" | ||
| DEFAULT_INI_FILE = "my.cnf" | ||
|
|
||
| def iniFileNameFromEnv(): | ||
| iniFromEnv = os.environ[INI_FILE_NAME_ENV] | ||
| return iniFromEnv if iniFromEnv else DEFAULT_INI_FILE | ||
|
|
||
| def run(): | ||
| config = configparser.ConfigParser() | ||
|
|
||
| iniContent = readFromEnv() | ||
| config.read_dict(iniContent) | ||
|
|
||
| with open(iniFileNameFromEnv(), 'w') as iniFile: | ||
| config.write(iniFile) | ||
|
|
||
|
|
||
| def readFromEnv(): | ||
| iniContent = collections.defaultdict(dict) | ||
| for envKey, value in os.environ.items(): | ||
| if envKey.startswith(CM_PREFIX): | ||
| _, section, key = envKey.split(DELIMITER) | ||
| iniContent[section][key] = value | ||
| return iniContent | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| run() | ||
| iniFile = os.path.abspath(iniFileNameFromEnv()) | ||
| if not exists(iniFile): | ||
| os.exit(1) | ||
| print(f"Successfully write to {iniFile}.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume there's also a program to generate this format from INI?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I actually just use the Sublime multi-line operation to convert the file.
To better reflect the Option 2 approach, added the python script to generate this from INI (second commit).