Add set-default-label function
#890
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwenma
force-pushed
the
set-default-label
branch
3 times, most recently
from
0063969 to
6cd9b92
Compare
mengqiy
reviewed
Jul 25, 2022
examples/set-default-labels-nested-package/app1_ghost/resources.yaml
Outdated
Show resolved
Hide resolved
examples/set-default-labels-nested-package/app2_mysql/README.md
Outdated
Show resolved
Hide resolved
examples/set-default-labels-nested-package/app2_mysql/README.md
Outdated
Show resolved
Hide resolved
yuwenma
force-pushed
the
set-default-label
branch
from
6cd9b92 to
51df837
Compare
|
@mengqiy Thank you! Ready for another look. |
yuwenma
force-pushed
the
set-default-label
branch
from
51df837 to
bd9b765
Compare
mengqiy
reviewed
Jul 26, 2022
yuwenma
force-pushed
the
set-default-label
branch
2 times, most recently
from
9cccffc to
2f5508a
Compare
mengqiy
reviewed
Jul 26, 2022
mengqiy
reviewed
Jul 26, 2022
|
This PR is waiting for some user message improvements from its dependent
|
yuwenma
force-pushed
the
set-default-label
branch
from
2f5508a to
04f3e9b
Compare
😆 my local branch has a different name (I rarely use different branch names) and obviously I forgot that after working on other stuff. |
mengqiy
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new set-default-labels function, based on the set-label transformer. It adds the recommended labels to follow the kpt label conventions.
Right now we only add app-name label, which uses the value from the root
Kptfilename. This convention believes that all KRM resources under the same kpt package should be served for a specific application.An application (or KPT package) can be composed by other applications (nested sub KPT packages).
So the function can accept multiple Kptfile and use the root Kptfile to set the app name.