Skip to content

Init go sdk dir #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2022
Merged

Init go sdk dir #517

merged 1 commit into from
Mar 5, 2022

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Feb 28, 2022 •
edited
Loading

Update: I'll need several PRs to have this work done. This PR is simplified to only merge the fnsdk from kpt-functions-catalog/thirdparty to this repo

TODO:

@yuwenma yuwenma force-pushed the gosdk branch 2 times, most recently from 8c770f1 to a2cfddc Compare March 1, 2022 16:53
@mengqiy
Copy link
Contributor

mengqiy commented Mar 1, 2022

Things related to the variant interface are all private. The implementation has been simplified in kubernetes-sigs/kustomize@b2f8309. I'd suggest using the implementation in this commit.

@mengqiy
Copy link
Contributor

mengqiy commented Mar 1, 2022

Why alpha directory is not under go dir?
Also if we have decided to fork kyaml and api package from kustomize, ideally we should fork the code in a separate PR (or at least a separate commit).

@yuwenma yuwenma force-pushed the gosdk branch 5 times, most recently from 6e886a1 to 3722365 Compare March 4, 2022 18:51
@mengqiy
Copy link
Contributor

mengqiy commented Mar 4, 2022

CI is failing please fix

@yuwenma yuwenma force-pushed the gosdk branch 4 times, most recently from 03787fe to 2c9e242 Compare March 4, 2022 22:56
@yuwenma yuwenma merged commit 4c54e1c into kptdev:master Mar 5, 2022
@yuwenma yuwenma deleted the gosdk branch March 5, 2022 00:22
@yuwenma yuwenma changed the title Init alpha dir, fork kyaml Init go sdk dir Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droot droot Awaiting requested review from droot

1 more reviewer

@mengqiy mengqiy mengqiy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuwenma @mengqiy