Open
Conversation
In the ``BJGK_Genesis_eNews_Extended`` class, the label class was changed to screen-reader-text that comes with all Genesis child themes. Plus it's the class WordPress introduced in 2009 https://www.google.com/search?q=wordpress+screen-reader-text&ie=utf-8&oe=utf-8
Author
|
I tested this out, and it works fine with MailChimp. The code is valid html when I use this in a widget twice on the page. The only time it is odd and this is something I would mark as "not fixing" is using inside a widget created with a page builder, it doesn't error and works, but the instance is #subbox1_enews_ext_REPLACE_TO_ID (for example) instead of #subbox1_enews_ext_4 (the number changes each instance). The way around that, which I will write up a post for, is to use the shortcode any widget plugin, create the instance in the widgets panel, and use a shortcode inside the page builder. Very easy work around. |
Repository owner
deleted a comment from
carasmo
Jun 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
screenreadclasses toscreen-reader-textused in all Genesis themesbutton