refactor: improve readability and consistency of Rust code by Lingxuan-Ye · Pull Request #1850 · krahets/hello-algo

Lingxuan-Ye · 2026-01-27T23:24:29Z

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

This PR represents the translation of a single, complete document, or contains only bug fixes.
The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:

I have thoroughly reviewed the code, focusing on its formatting, comments, indentation, and file headers.
I have confirmed that the code execution outputs are consistent with those produced by the reference code (Python or Java).
The code is designed to be compatible on standard operating systems, including Windows, macOS, and Ubuntu.

Lingxuan-Ye · 2026-01-28T09:29:39Z

修复了 4 项错误和 89 项警告；
修复了大量 unsound 的类型 cast；
提高了程序在合法 corner cases 下的健壮性；
移除示例代码中的所有 unwrap 调用；
重写了 lib hello_algo_rust 并解耦了所有 bin crates。

rongyi · 2026-01-30T07:13:13Z

unwrap其实没什么，大量的加 pub 其实没必要，我觉得可以精炼一下，那些 print 主要是兼容其他语言，建议轻易不要动。否则，看几个 commit 就不想看了。

Lingxuan-Ye · 2026-01-30T07:30:51Z

其他语言使用 print 的我都没有移除 print 方法；
unwrap 我只是额外分析了可达性，并没有提高复杂度；
关于 pub 请看我添加的维护指南；
我认为教程示例应该指导初学者编写正确、规范的代码，目前代码存在大量警告和 unsound 逻辑，我认为有必要修复这些。

First of all, these comments should not be doc comments because they do not document or explain any bit of the crates. Secondly, they should never be outer doc comments, as outer doc comments document items right below rather than the crates. It is just wrong.

Removed: - `clippy::let_and_return`

Removed: - `clippy::assign_op_pattern` - `clippy::let_and_return` Explicitly omitted: - `clippy::manual_swap`

Removed: - `clippy::needless_return` Explicitly omitted: - `dead_code` - `unused_variables`

When it comes to spatial overhead, `usize` should be used.

Explicitly omitted: - `clippy::manual_find` - `clippy::needless_range_loop`

Removed: - `clippy::let_and_return` Explicitly omitted: - `unused_variables` - `unused_assignments` - `clippy::needless_range_loop` - `clippy::manual_find`

Explicitly omitted: - `unused_variables` - `unused_assignments` - `clippy::needless_range_loop`

Removed: - `clippy::needless_return`

…ND_RATIO`

Explicitly omitted: - `clippy::vec_init_then_push`

Removed: - `clippy::needless_return` Explicitly omitted: - `clippy::new_without_default`

Explicitly omitted: - `clippy::new_without_default`

Removed: - `clippy::assign_op_pattern`

Removed: - `clippy::let_and_return`

Removed: - `clippy::needless_range_loop`

Removed: - `clippy::ptr_arg` - `clippy::assign_op_pattern` Explicitly omitted: - `clippy::needless_range_loop`

Refer to codes/rust/GUIDELINES.md for more information.

Removed: - `clippy::needless_return` - `clippy::self_assignment`

Lingxuan-Ye · 2026-02-05T19:31:57Z

重写了 git 历史以方便 review 并修改了部分不一致的代码。

Removed: - `clippy::needless_return` - `clippy::self_assignment`

…ypes with `Option<u32>`

Removed: - `clippy::self_assignment` - `clippy::assign_op_pattern`

…with `Option<u32>`

Lingxuan-Ye force-pushed the dev branch from dd2a179 to 7fe3b57 Compare January 27, 2026 23:30

Lingxuan-Ye added 26 commits February 5, 2026 17:27

docs: add GUIDELINES.md

48f666a

build: bump edition to "2024"

56b2f49

build: update dependency

a838f54

feat: add support modules

9077815

refactor: adjust visibility according to codes/rust/GUIDELINES.md

81ffbfe

refactor: use a more intuitive way to join strings

0a09bcb

perf: eliminate unnecessary branch jump in Option::unwrap

a647b7e

fix: resolve warning

dc5ea1d

Removed: - `clippy::let_and_return`

fix: resolve warnings

72232ee

Removed: - `clippy::assign_op_pattern` - `clippy::let_and_return` Explicitly omitted: - `clippy::manual_swap`

fix: resolve warnings

cb80ebe

Removed: - `clippy::needless_return` Explicitly omitted: - `dead_code` - `unused_variables`

refactor: replace all n types with usize

1870e88

When it comes to spatial overhead, `usize` should be used.

refactor: simplify code

9080fb4

fix: resolve warnings

e303758

Explicitly omitted: - `clippy::manual_find` - `clippy::needless_range_loop`

fix: resolve warnings

09839e3

Removed: - `clippy::let_and_return` Explicitly omitted: - `unused_variables` - `unused_assignments` - `clippy::needless_range_loop` - `clippy::manual_find`

refactor: simplify code

560e79c

fix: resolve warnings

de9e7c3

Explicitly omitted: - `unused_variables` - `unused_assignments` - `clippy::needless_range_loop`

fix: resolve warning

86b72d0

Removed: - `clippy::needless_return`

fix: resolve a bug where capacity remained 0 when supposed to grow

cf8163b

refactor: replace field extend_ratio with associated constant `EXTE…

99fcfed

…ND_RATIO`

refactor: rewrite formatted output logic

ca4b3d3

fix: resolve warning

3681662

Explicitly omitted: - `clippy::vec_init_then_push`

refactor: rewrite LinkedListStack::pop and LinkedListStack::to_array

1a57965

fix: resolve warnings

9321f08

Removed: - `clippy::needless_return` Explicitly omitted: - `clippy::new_without_default`

refactor: rewrite formatted output logic

981797a

fix: resolve warning

1849698

Explicitly omitted: - `clippy::new_without_default`

Lingxuan-Ye added 16 commits February 6, 2026 01:37

refactor: replace the type of i with usize to avoid truncation

573939b

refactor: simplify code and improve consistency

961ca96

refactor: rewrite to conform to template code

4870225

refactor: improve readability

9ff5ba3

refactor: trivial changes

d8e47e9

perf: eliminate unnecessary heap allocation for strings

cc2a684

fix: resolve warning

2591f42

Removed: - `clippy::assign_op_pattern`

refactor: replace all integer types with u32

79f744f

perf: eliminate unnecessary heap allocations

84121e3

fix: resolve warning

00a2f3a

Removed: - `clippy::let_and_return`

fix: resolve warning

933b783

Removed: - `clippy::needless_range_loop`

refactor: replace all integer types with u32

10d0b0b

fix: resolve warnings

7c2e999

Removed: - `clippy::ptr_arg` - `clippy::assign_op_pattern` Explicitly omitted: - `clippy::needless_range_loop`

refactor: replace cost type with u32 and index type with usize

0411e4c

Refer to codes/rust/GUIDELINES.md for more information.

fix: resolve warning

7b9a668

Removed: - `clippy::needless_return` - `clippy::self_assignment`

refactor: replace all integer types except indices with u32

ce698aa

Lingxuan-Ye force-pushed the dev branch from 62ae094 to 3db9a12 Compare February 5, 2026 19:27

Lingxuan-Ye added 10 commits February 6, 2026 04:07

perf: replace strings with char arrays for O(1) access

e9244fc

fix: resolve warning

f820a04

Removed: - `clippy::needless_return` - `clippy::self_assignment`

refactor: replace all input integer types with u32 and all return t…

de91999

…ypes with `Option<u32>`

fix: resolve warning

7a58853

Removed: - `clippy::self_assignment` - `clippy::assign_op_pattern`

refactor: replace all integer types with u32

21b3334

refactor: replace all input integer types with u32 and return type …

bf33f65

…with `Option<u32>`

refactor: replace all integer types with u32

2ae41a7

refactor!: remove mod include

663e7d1

docs: remove leading underscores

b2b4b18

docs: remove redundant code

6659238

Lingxuan-Ye force-pushed the dev branch from 3db9a12 to 6659238 Compare February 5, 2026 20:07

docs: reword

ec03329

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: improve readability and consistency of Rust code#1850

refactor: improve readability and consistency of Rust code#1850
Lingxuan-Ye wants to merge 109 commits intokrahets:mainfrom
Lingxuan-Ye:dev

Lingxuan-Ye commented Jan 27, 2026

Uh oh!

Lingxuan-Ye commented Jan 28, 2026

Uh oh!

rongyi commented Jan 30, 2026

Uh oh!

Lingxuan-Ye commented Jan 30, 2026

Uh oh!

Lingxuan-Ye commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Lingxuan-Ye commented Jan 27, 2026

Uh oh!

Lingxuan-Ye commented Jan 28, 2026

Uh oh!

rongyi commented Jan 30, 2026

Uh oh!

Lingxuan-Ye commented Jan 30, 2026

Uh oh!

Lingxuan-Ye commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants