Fix confusion between queSize and rear pointer in ArrayQueue implemen…#1851
Open
Kunchen-Luo wants to merge 1 commit intokrahets:mainfrom
Open
Fix confusion between queSize and rear pointer in ArrayQueue implemen…#1851Kunchen-Luo wants to merge 1 commit intokrahets:mainfrom
Kunchen-Luo wants to merge 1 commit intokrahets:mainfrom
Conversation
…tation - `queSize` represents the queue's size, not the rear pointer position. - In `pop`, `queSize--` decreases the size, not the rear pointer. - The rear pointer is calculated using modulo (`%`) with the `front` and `queSize` to avoid confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarifies the meaning of
queSizein the ArrayQueue implementation.queSizerepresents the current size of the queue rather than the rear pointer position.In the
popfunction,queSize--decreases the queue size, which could be confusing for beginners if interpreted as moving the rear pointer.The rear index is actually calculated using modulo (%) with
frontandqueSize.This change only improves comments and readability; no functional logic is modified.
Please let me know if any adjustments are needed. Thanks!