Skip to content

Conversation

Deepak-Rathore580
Copy link

While compiling lxc with clang, it fails with compilation error and not compatible with clang compiler. Hence, updated TOOLCHAIN of lxc to use gcc.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

While compiling lxc with clang, it fails with compilation error
and not compatible with clang compiler. Hence, updated TOOLCHAIN
of lxc to use gcc.

Signed-off-by: Deepak Rathore <[email protected]>

# Does not compile with clang 18
# ERROR: LLVM's thinLTO only works with gnu gold, lld, lld-link, and ld64, not ld.bfd
TOOLCHAIN:pn-lxc = "gcc"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not enable thin-lto by default, but its a possible DISTRO_FEATURE so it might be better to check for this in DISTRO_FEATURES and then resort to always using gcc toolchain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants