Skip to content

layer.conf: drop LLVMVERSION#1143

Merged
kraj merged 4 commits intokraj:masterfrom
shr-project:jansa/master
Dec 12, 2025
Merged

layer.conf: drop LLVMVERSION#1143
kraj merged 4 commits intokraj:masterfrom
shr-project:jansa/master

Conversation

@shr-project
Copy link
Contributor

The recipes were removed from this layer and this version doesn't match with the clang version in oe-core (currently 21.1.7).

Better to drop this variable now as it's just confusing and if someone needs to find a path to clang lib files like:
recipe-sysroot/usr/lib/clang/18.1.6/lib/linux
we need to use some other variable to do that.

scripts/devtool-clang.sh still references this variable, but I guess the script isn't used anymore.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

The recipes were removed from this layer and this version doesn't match
with the clang version in oe-core (currently 21.1.7).

Better to drop this variable now as it's just confusing and if someone
needs to find a path to clang lib files like:
recipe-sysroot/usr/lib/clang/18.1.6/lib/linux
we need to use some other variable to do that.

scripts/devtool-clang.sh still references this variable, but I guess
the script isn't used anymore.

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
@shr-project shr-project requested a review from kraj as a code owner December 11, 2025 21:03
@kraj
Copy link
Owner

kraj commented Dec 12, 2025

its still used in scripts/devtool-clang.sh eventhough I doubt the use of this script, it was for using a local development tree of llvm ( mainly for LLVM development) but since it moved to code it might not be relevant anymore. So would you mind sending a patch to remove this script as well ?

It probably wasn't actively used for a while, it was last user of LLVMVERSION
variable which wasn't set correctly and was removed in previous commit

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
compiler-rt recipe is now in oe-core and the described issue doesn't
happen anymore.

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
@shr-project
Copy link
Contributor Author

its still used in scripts/devtool-clang.sh eventhough I doubt the use of this script, it was for using a local development tree of llvm ( mainly for LLVM development) but since it moved to code it might not be relevant anymore. So would you mind sending a patch to remove this script as well ?

OK, done.

Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kraj kraj merged commit cf20f8b into kraj:master Dec 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants