Merged
Conversation
meshy
approved these changes
Sep 22, 2025
Collaborator
meshy
left a comment
meshy
left a comment
There was a problem hiding this comment.
This is great, thanks! Only blocker is that I think we need to add cache keys before leaning into the pip caches.
Collaborator
There was a problem hiding this comment.
Issue: If we're setting up the cache, I think we need to define a key per group.
Collaborator
Author
There was a problem hiding this comment.
Ahh good point! I'll do that.
Collaborator
Author
There was a problem hiding this comment.
This action doesn't give us access to the key -- it's generated from the relevant files (in our case pyproject.toml). I'll remove it from here.
`mkdocs` builds the docs into a `site/` directory, which should not be version-controlled.
This ensures the docs can always be built.
This allows us to update the Python version for all workflows in one place.
This ensures we don't publish docs for non-existent versions, or where there was some problem with the release process.
This clarifies what is being published (since another job publishes the docs).
samueljsb
force-pushed
the
docs-in-ci
branch
from
77979fd to
2e67686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publishjob topypiResolves #45