Set up backfill log with separate positive and negative ranges #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report Results
1 empty file skipped. |
timb07
force-pushed
the
backfill-positive-negative
branch
from
45b8a95 to
ee0668b
Compare
marcelofern
approved these changes
Jun 18, 2025
Collaborator
marcelofern
left a comment
marcelofern
left a comment
There was a problem hiding this comment.
LGTM.
Worth noting though that the get_min_and_max_pk() function only gets used by the _populate_backfill_log, so we could return negative/positive ranges directly from it to avoid a couple of round-trips to the db. But not a big deal here.
tests/factories.py
Outdated
Comment on lines
238
to
239
| INSERT INTO {table_name} ("id") | ||
| SELECT "gs" FROM generate_series(1, {positive_rows}) AS gs; |
Collaborator
There was a problem hiding this comment.
🍷 You should be able to simplify the "gs" bits off:
INSERT INTO {table_name} (id) SELECT generate_series(1, {positive_rows});
tests/factories.py
Outdated
Comment on lines
247
to
249
| INSERT INTO {table_name} ("id") | ||
| SELECT "gs" | ||
| FROM generate_series({negative_base}, {negative_base} + {negative_rows} - 1) AS gs; |
Prior to this change, if the table being repacked used negative pk values, the backfill would cover the entire range from min(pk) to 0 (as well as the positive values). When negative pk values have been used after positive values are nearing exhaustion, it's likely that most of the negative range is empty and therefore does not need to be backfilled. This change checks for min(pk) and max(pk) separately for positive values and negative values, to avoid backfilling empty negative ranges.
timb07
force-pushed
the
backfill-positive-negative
branch
from
ee0668b to
801b0e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if the table being repacked used negative pk values, the backfill would cover the entire range from min(pk) to 0 (as well as the positive values). When negative pk values have been used after positive values are nearing exhaustion, it's likely that most of the negative range is empty and therefore does not need to be backfilled.
This change checks for min(pk) and max(pk) separately for positive values and negative values, to avoid backfilling empty negative ranges.