Make "PostBackfillBatchCallback" public #43
Conversation
Coverage Report Results
1 empty file skipped. |
| NoReferencesPrivilege, | ||
| NoReferringTableOwnership, | ||
| NotTableOwner, | ||
| PostBackfillBatchCallback, |
There was a problem hiding this comment.
I'm not sure PostBackfillBatchCallback itself needs to be public. I'd assume that type checking would work regardless of this change. What kind of issue has popped up? I wonder if it could be a red herring
One thing I think would be useful to make public is It's already public, I'm a dummy_introspect.BackfillBatch, since that's something users could use when implementing a post backfill batch callback.
There was a problem hiding this comment.
I used PostBackfillBatchCallback here.
Perhaps the justification for it in the description is a bit weak. It's useful if you're declaring your own function that takes an argument with type PostBackfillBatchCallback and passes that through to Psycopack.
One thing I think would be useful to make public is _introspect.BackfillBatch, since that's something users could use when implementing a post backfill batch callback.
It is already :)
There was a problem hiding this comment.
Ah got it, you want to use for a type annotation 👍 Makes sense
It is already :)
Yeah I noticed after I wrote it 🤦
This change makes
PostBackfillBatchCallbackpublic, so that whenPsycopackis instantiated with apost_backfill_batch_callbackargument, type checking the argument is possible.