Fix handling of PK sequence value #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report Results
1 empty file skipped. |
Prior to this change, the current value of the table's PK sequence wasn't transferred to the repacked table's PK sequence. Without that, new rows would be inserted into the repacked table starting with a PK value of 1 (which would likely conflict with existing rows). This change adds a command during swap to transfer the sequence value from one table to the other. There is also special handling for the edge case of a bigint conversion where the PK sequence has been set to negative (presumably after positive PK values were exhausted); in that case, the sequence is reset to the first positive bigint value not within the integer range, which is 2**31. Note that this edge case won't be handled correctly during a revert_swap(); addressing that is left as a TODO for later.
timb07
force-pushed
the
fix-pk-sequence-value
branch
from
aa16c41 to
0ca8f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the current value of the table's PK sequence wasn't transferred to the repacked table's PK sequence. Without that, new rows would be inserted into the repacked table starting with a PK value of 1 (which would likely conflict with existing rows).
This change adds a command during swap to transfer the sequence value from one table to the other. There is also special handling for the edge case of a bigint conversion where the PK sequence has been set to negative (presumably after positive PK values were exhausted); in that case, the sequence is reset to the first positive bigint value not within the integer range, which is 2**31. Note that this edge case won't be handled correctly during a
revert_swap(); addressing that is left as a TODO for later.