Disallow deferrable unique constraints #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report Results
1 empty file skipped. |
timb07
force-pushed
the
disallow-deferrable-unique-constraint
branch
from
f0d2e81 to
617b899
Compare
timb07
force-pushed
the
disallow-deferrable-unique-constraint
branch
2 times, most recently
from
a589f56 to
3d22d07
Compare
marcelofern
approved these changes
Sep 8, 2025
Collaborator
marcelofern
left a comment
marcelofern
left a comment
There was a problem hiding this comment.
A good amount of clarification in this Postgres mailing list thread
Prior to this change, if Psycopack was used on a table with a deferrable
unique constraint, then after the "sync_schemas" stage, any updates to the original
table would cause the trigger that updates the psycopack table to fail with
this error:
ON CONFLICT does not support deferrable unique constraints/exclusion
constraints as arbiters
That error results from the use of "ON CONFLICT DO NOTHING" in the copy
function used by the trigger.
This change removes test coverage of deferrable unique constraints and adds
a check to the pre_validate stage to reject a table that has a deferrable
unique constraint.
timb07
force-pushed
the
disallow-deferrable-unique-constraint
branch
from
3d22d07 to
f7314da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if Psycopack was used on a table with a deferrable unique constraint, then after the
swapsync_schemasstage, any updates to the original table would cause the trigger that updates the psycopack table to fail with this error:That error results from the use of
ON CONFLICT DO NOTHINGin the copy function used by the trigger.This change removes test coverage of deferrable unique constraints and adds a check to the
pre_validatestage to reject a table that has a deferrable unique constraint.(This issue was discovered while working on tests to reproduce the bug in #49.)