Skip to content

Refactor pyo3 usage #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LilyFirefly merged 6 commits into from
Aug 4, 2025
Merged

Refactor pyo3 usage #27

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6455f6c
Use PyO3 declarative module syntax
LilyFirefly Aug 1, 2025
9dc68e6
Raise a ValueError instead of panicking for invalid language
LilyFirefly Aug 1, 2025
76af155
Use tuple unpacking in for loop
LilyFirefly Aug 1, 2025
245266e
Simplify setting FluentArgs based on Python type
LilyFirefly Aug 1, 2025
ab7c4b1
Move errors Vec next to bundle.format_pattern call site
LilyFirefly Aug 1, 2025
e0e068d
Simplify non-strict error handling with tuple unpacking
LilyFirefly Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,9 @@ mod rustfluent {
let mut args = FluentArgs::new();

if let Some(variables) = variables {
for variable in variables {
for (python_key, python_value) in variables {
Copy link
Collaborator

@seddonym seddonym Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer. 😄

// Make sure the variable key is a Python string,
// raising a TypeError if not.
let python_key = variable.0;
if !python_key.is_instance_of::<PyString>() {
return Err(PyTypeError::new_err(format!(
"Variable key not a str, got {python_key}."
Expand All @@ -101,7 +100,6 @@ mod rustfluent {
let key = python_key.to_string();
// Set the variable value as a string or integer,
// raising a TypeError if not.
let python_value = variable.1;
if python_value.is_instance_of::<PyString>() {
args.set(key, python_value.to_string());
} else if python_value.is_instance_of::<PyInt>() {
Expand Down