Merged
Conversation
This better describes what the environment is for.
This avoids specifying dependencies twice to get them into the mypy environment in pre-commit. It also means we get mypy running in parallel with tests and od not need to wait for it when we commit.
samueljsb
force-pushed
the
mypy-in-tox
branch
from
7912347 to
775c51a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids specifying dependencies twice to get them into the mypy
environment in pre-commit. It also means we get mypy running in parallel
with tests and do not need to wait for it when we commit.