Conditionally add unload event listener (enable bfcache)#127
Merged
Conversation
nikrom17
force-pushed
the
feature/pagehide
branch
3 times, most recently
from
ccdffc8 to
4565da1
Compare
gregjopa
reviewed
Jan 7, 2026
| window.addEventListener("pagehide", () => win.close()); | ||
| window.addEventListener("unload", () => win.close()); | ||
| window.addEventListener("beforeunload", () => win.close()); | ||
| window.addEventListener("beforeunload", () => { |
Contributor
There was a problem hiding this comment.
Great to see beforeunload kept here. From previously testing, beforeunload is required to ensure the popup is closed when the user closes the merchant page.
gregjopa
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements BFCache (Back/Forward Cache) compatibility for smart payment buttons by replacing blocking beforeunload and unload event listeners with BFCache-compatible pagehide events. This enables instant back/forward navigation for users, improving the browsing experience by allowing browsers to cache entire pages in memory.
https://paypal.atlassian.net/browse/DTPPCPSDK-2854