fix: resolveModuleDirectory with exports fields#27
Merged
imbrian merged 18 commits intokrakenjs:mainfrom May 14, 2025
Merged
Conversation
wsbrunson
approved these changes
May 12, 2025
wsbrunson
approved these changes
May 14, 2025
imbrian
force-pushed
the
feature/exports-fields
branch
from
36d661b to
d75b3d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveModuleDirectoryis unable to resolve packages withexportsfields that don't includepackage.jsonas an entry-point, because it attempts require.resolve(${name}/package.json). adding a second step to attempt to resolve just the module name, then step up the tree from the resolved path to find the package's manifest.