Enable minimap in defer window mode #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
commented
Jul 18, 2025
| protected onUpdateRequest(msg: Message): void { | ||
| // This is a no-op. | ||
| // @ts-ignore | ||
| this.parent?._update(); |
Author
There was a problem hiding this comment.
This is obviously hacky.
We can't call this.parent.update() since it would result in an infinite update loop.
Happy to discuss a better approach though. Maybe introducing a new public rerender method in the parent?
Owner
There was a problem hiding this comment.
I think adding rerender sounds fine if required.
krassowski
reviewed
Jul 19, 2025
Owner
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
Thanks @martinRenou! What would you think about opening this as a PR against JupyterLab (disregarding the switch to defer)? My thinking is that this can be merged and tested before we are ready to merge the change to defer by default.
| protected onUpdateRequest(msg: Message): void { | ||
| // This is a no-op. | ||
| // @ts-ignore | ||
| this.parent?._update(); |
Owner
There was a problem hiding this comment.
I think adding rerender sounds fine if required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.