Skip to content

Commit 374a3b3

Browse files
committed
Merge branch 'openUI5' of https://github.com/albertlast/js-framework-benchmark into albertlast-openUI5
2 parents 977d5d1 + 506d7c9 commit 374a3b3

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

frameworks/non-keyed/openui5/webapp/element/MyLinkRenderer.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,10 @@ sap.ui.define(
161161
// opening <a> tag
162162
oRm.openEnd();
163163
oRm.openStart("span");
164+
oRm.class("remove");
164165
oRm.class("glyphicon");
165166
oRm.class("glyphicon-remove");
167+
oRm.attr("aria-hidden", "true");
166168
oRm.openEnd();
167169
oRm.close("span");
168170

frameworks/non-keyed/openui5/webapp/element/MyTableRenderer.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,10 @@ sap.ui.define(
380380
"aria-roledescription",
381381
Library.getResourceBundleFor("sap.m").getText("TABLE_ROLE_DESCRIPTION")
382382
);
383-
rm.class("sapMListTbl");
383+
rm.class("table");
384+
rm.class("table-hover");
385+
rm.class("table-striped");
386+
rm.class("test-data");
384387

385388
if (oControl.getFixedLayout() === false) {
386389
rm.style("table-layout", "auto");

frameworks/non-keyed/openui5/webapp/view/DataList.view.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
xmlns:html="http://www.w3.org/1999/xhtml"
66
xmlns:element="ui5.benchmark.element">
77

8-
<element:MyTable items="{list>/elements}" class="table table-hover table-striped test-data">
8+
<element:MyTable items="{list>/elements}">
99
<element:columns>
1010
<Column width="12em">
1111
<Text text="Product" />
@@ -24,8 +24,8 @@
2424
<element:MyColumnListItem vAlign="Middle">
2525
<element:cells>
2626
<element:MyText text="{list>id}" />
27-
<Link href="#" text="{list>label}" press="selectRow"/>
28-
<element:MyLink text="delete" press="deleteRow"/>
27+
<Link class="lbl" href="#" text="{list>label}" press="selectRow"/>
28+
<element:MyLink class="remove" text="delete" press="deleteRow"/>
2929
<element:MyObjectIdentifier text="{list>id}"/>
3030
</element:cells>
3131
</element:MyColumnListItem>

0 commit comments

Comments
 (0)