fix #1222

krausest · krausest · commit 38c8ee7c5645 · 2023-11-26T20:58:01.000+01:00
diff --git a/webdriver-ts/src/benchmarksCommon.ts b/webdriver-ts/src/benchmarksCommon.ts
@@ -192,7 +192,7 @@ export const cpuBenchmarkInfosArray: Array<CPUBenchmarkInfo> = [
     id: Benchmark._08,
     label: "append rows to large table",
     description: (throttleCPU: number | undefined) =>
-      "appending 1,000 to a table of 10,000 rows." + slowDownNote(throttleCPU),
+      "appending 1,000 to a table of 1,000 rows." + slowDownNote(throttleCPU),
     type: BenchmarkType.CPU,
     allowBatching: true,
     layoutEventRequired: true,
diff --git a/webdriver-ts/src/benchmarksPlaywright.ts b/webdriver-ts/src/benchmarksPlaywright.ts
@@ -184,6 +184,12 @@ export const benchAppendToManyRows = new (class extends CPUBenchmarkPlaywright {
   }
   async init(browser: Browser, page: Page) {
     await checkElementExists(page, "#run");
+    for (let i = 0; i < config.WARMUP_COUNT; i++) {
+      await clickElement(page, "#run");
+      await checkElementContainsText(page, "tbody>tr:nth-of-type(1)>td:nth-of-type(1)", (i*1000+1).toFixed());
+      await clickElement(page, "#clear");
+      await checkElementNotExists(page, "tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");
+    }
     await clickElement(page, "#run");
     await checkElementExists(page, "tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");
   }
diff --git a/webdriver-ts/src/benchmarksPuppeteer.ts b/webdriver-ts/src/benchmarksPuppeteer.ts
@@ -183,6 +183,12 @@ export const benchAppendToManyRows = new (class extends CPUBenchmarkPuppeteer {
   }
   async init(page: Page) {
     await checkElementExists(page, "pierce/#run");
+    for (let i = 0; i < config.WARMUP_COUNT; i++) {
+      await clickElement(page, "pierce/#run");
+      await checkElementContainsText(page, "pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(1)", (i*1000+1).toFixed());
+      await clickElement(page, "pierce/#clear");
+      await checkElementNotExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");
+    }    
     await clickElement(page, "pierce/#run");
     await checkElementExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");
   }
diff --git a/webdriver-ts/src/benchmarksWebdriver.ts b/webdriver-ts/src/benchmarksWebdriver.ts
@@ -175,12 +175,18 @@ export const benchAppendToManyRows = new (class extends CPUBenchmarkWebdriver {
   }
   async init(driver: WebDriver) {
     await testElementLocatedById(driver, "run", SHORT_TIMEOUT, true);
+    for (let i = 0; i < config.WARMUP_COUNT; i++) {
+      await clickElementById(driver, "run", true);
+      await testTextContains(driver, "//tbody/tr[1]/td[1]", (i * 1000 + 1).toFixed(), config.TIMEOUT, false);
+      await clickElementById(driver, "clear", true);
+      await testElementNotLocatedByXPath(driver, "//tbody/tr[1]", config.TIMEOUT, false);
+    }
     await clickElementById(driver, "run", true);
     await testElementLocatedByXpath(driver, "//tbody/tr[1000]/td[2]/a", config.TIMEOUT, false);
   }
   async run(driver: WebDriver) {
     await clickElementById(driver, "add", true);
-    await testElementLocatedByXpath(driver, "//tbody/tr[1100]/td[2]/a", config.TIMEOUT, false);
+    await testElementLocatedByXpath(driver, "//tbody/tr[2000]/td[2]/a", config.TIMEOUT, false);
   }
 })();
 
diff --git a/webdriver-ts/src/benchmarksWebdriverAfterframe.ts b/webdriver-ts/src/benchmarksWebdriverAfterframe.ts
@@ -273,12 +273,18 @@ export const benchAppendToManyRows = new (class extends CPUBenchmarkWebdriver {
   }
   async init(driver: WebDriver) {
     await testElementLocatedById(driver, "run", SHORT_TIMEOUT, true);
+    for (let i = 0; i < config.WARMUP_COUNT; i++) {
+      await clickElementById(driver, "run", true);
+      await testTextContains(driver, "//tbody/tr[1]/td[1]", (i * 1000 + 1).toFixed(), config.TIMEOUT, false);
+      await clickElementById(driver, "clear", true);
+      await testElementNotLocatedByXPath(driver, "//tbody/tr[1]", config.TIMEOUT, false);
+    }
     await clickElementById(driver, "run", true);
     await testElementLocatedByXpath(driver, "//tbody/tr[1000]/td[2]/a", config.TIMEOUT, false);
   }
   async run(driver: WebDriver) {
     await measureClickElementById(driver, "add", true);
-    await testElementLocatedByXpath(driver, "//tbody/tr[1100]/td[2]/a", config.TIMEOUT, false);
+    await testElementLocatedByXpath(driver, "//tbody/tr[2000]/td[2]/a", config.TIMEOUT, false);
   }
 })();
 
diff --git a/webdriver-ts/src/benchmarksWebdriverCDP.ts b/webdriver-ts/src/benchmarksWebdriverCDP.ts
@@ -175,12 +175,18 @@ export const benchAppendToManyRows = new (class extends CPUBenchmarkWebdriverCDP
   }
   async init(driver: WebDriver) {
     await testElementLocatedById(driver, "run", SHORT_TIMEOUT, true);
+    for (let i = 0; i < config.WARMUP_COUNT; i++) {
+      await clickElementById(driver, "run", true);
+      await testTextContains(driver, "//tbody/tr[1]/td[1]", (i * 1000 + 1).toFixed(), config.TIMEOUT, false);
+      await clickElementById(driver, "clear", true);
+      await testElementNotLocatedByXPath(driver, "//tbody/tr[1]", config.TIMEOUT, false);
+    }
     await clickElementById(driver, "run", true);
     await testElementLocatedByXpath(driver, "//tbody/tr[1000]/td[2]/a", config.TIMEOUT, false);
   }
   async run(driver: WebDriver) {
     await clickElementById(driver, "add", true);
-    await testElementLocatedByXpath(driver, "//tbody/tr[1100]/td[2]/a", config.TIMEOUT, false);
+    await testElementLocatedByXpath(driver, "//tbody/tr[2000]/td[2]/a", config.TIMEOUT, false);
   }
 })();
 

Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,12 @@ export const benchAppendToManyRows = new (class extends CPUBenchmarkPlaywright {`
`184`	`184`	`}`
`185`	`185`	`async init(browser: Browser, page: Page) {`
`186`	`186`	`await checkElementExists(page, "#run");`
	`187`	`+ for (let i = 0; i < config.WARMUP_COUNT; i++) {`
	`188`	`+ await clickElement(page, "#run");`
	`189`	`+ await checkElementContainsText(page, "tbody>tr:nth-of-type(1)>td:nth-of-type(1)", (i*1000+1).toFixed());`
	`190`	`+ await clickElement(page, "#clear");`
	`191`	`+ await checkElementNotExists(page, "tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");`
	`192`	`+ }`
`187`	`193`	`await clickElement(page, "#run");`
`188`	`194`	`await checkElementExists(page, "tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");`
`189`	`195`	`}`
Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,12 @@ export const benchAppendToManyRows = new (class extends CPUBenchmarkPuppeteer {`
`183`	`183`	`}`
`184`	`184`	`async init(page: Page) {`
`185`	`185`	`await checkElementExists(page, "pierce/#run");`
	`186`	`+ for (let i = 0; i < config.WARMUP_COUNT; i++) {`
	`187`	`+ await clickElement(page, "pierce/#run");`
	`188`	`+ await checkElementContainsText(page, "pierce/tbody>tr:nth-of-type(1)>td:nth-of-type(1)", (i*1000+1).toFixed());`
	`189`	`+ await clickElement(page, "pierce/#clear");`
	`190`	`+ await checkElementNotExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");`
	`191`	`+ }`
`186`	`192`	`await clickElement(page, "pierce/#run");`
`187`	`193`	`await checkElementExists(page, "pierce/tbody>tr:nth-of-type(1000)>td:nth-of-type(1)");`
`188`	`194`	`}`
Original file line number	Diff line number	Diff line change
`@@ -175,12 +175,18 @@ export const benchAppendToManyRows = new (class extends CPUBenchmarkWebdriver {`
`175`	`175`	`}`
`176`	`176`	`async init(driver: WebDriver) {`
`177`	`177`	`await testElementLocatedById(driver, "run", SHORT_TIMEOUT, true);`
	`178`	`+ for (let i = 0; i < config.WARMUP_COUNT; i++) {`
	`179`	`+ await clickElementById(driver, "run", true);`
	`180`	`+ await testTextContains(driver, "//tbody/tr[1]/td[1]", (i * 1000 + 1).toFixed(), config.TIMEOUT, false);`
	`181`	`+ await clickElementById(driver, "clear", true);`
	`182`	`+ await testElementNotLocatedByXPath(driver, "//tbody/tr[1]", config.TIMEOUT, false);`
	`183`	`+ }`
`178`	`184`	`await clickElementById(driver, "run", true);`
`179`	`185`	`await testElementLocatedByXpath(driver, "//tbody/tr[1000]/td[2]/a", config.TIMEOUT, false);`
`180`	`186`	`}`
`181`	`187`	`async run(driver: WebDriver) {`
`182`	`188`	`await clickElementById(driver, "add", true);`
`183`		`- await testElementLocatedByXpath(driver, "//tbody/tr[1100]/td[2]/a", config.TIMEOUT, false);`
	`189`	`+ await testElementLocatedByXpath(driver, "//tbody/tr[2000]/td[2]/a", config.TIMEOUT, false);`
`184`	`190`	`}`
`185`	`191`	`})();`
`186`	`192`
Original file line number	Diff line number	Diff line change
`@@ -273,12 +273,18 @@ export const benchAppendToManyRows = new (class extends CPUBenchmarkWebdriver {`
`273`	`273`	`}`
`274`	`274`	`async init(driver: WebDriver) {`
`275`	`275`	`await testElementLocatedById(driver, "run", SHORT_TIMEOUT, true);`
	`276`	`+ for (let i = 0; i < config.WARMUP_COUNT; i++) {`
	`277`	`+ await clickElementById(driver, "run", true);`
	`278`	`+ await testTextContains(driver, "//tbody/tr[1]/td[1]", (i * 1000 + 1).toFixed(), config.TIMEOUT, false);`
	`279`	`+ await clickElementById(driver, "clear", true);`
	`280`	`+ await testElementNotLocatedByXPath(driver, "//tbody/tr[1]", config.TIMEOUT, false);`
	`281`	`+ }`
`276`	`282`	`await clickElementById(driver, "run", true);`
`277`	`283`	`await testElementLocatedByXpath(driver, "//tbody/tr[1000]/td[2]/a", config.TIMEOUT, false);`
`278`	`284`	`}`
`279`	`285`	`async run(driver: WebDriver) {`
`280`	`286`	`await measureClickElementById(driver, "add", true);`
`281`		`- await testElementLocatedByXpath(driver, "//tbody/tr[1100]/td[2]/a", config.TIMEOUT, false);`
	`287`	`+ await testElementLocatedByXpath(driver, "//tbody/tr[2000]/td[2]/a", config.TIMEOUT, false);`
`282`	`288`	`}`
`283`	`289`	`})();`
`284`	`290`