Open
Conversation
|
Great @jerefrer |
Contributor
|
I'm not a simpleform user, can anyone verify this works? |
Contributor
Author
|
Ok I just refactored the code to extract everything that's not directly related to the form builder gem. Much cleaner now. Though I could not test against Formtastic. Could someone do that ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Here's a working version of the RichInput and RichPickerInput for SimpleForm.
For both I just copied the input code and wrapped it in a
if Object.const_defined?("SimpleForm")block, so it's far from DRY but at least you have the SimpleForm equivalent of your Formtastic inputs.May this be a first step toward SimpleForm compatibility :)