feat(core): centralize snake_to_camel and fix FFI casing leakage#446
Merged
feat(core): centralize snake_to_camel and fix FFI casing leakage#446
Conversation
kh3rld
added
enhancement
Goldziher
reviewed
Mar 7, 2026
CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| - **Centralized FFI metadata casing**: Moved `snake_to_camel` recursive JSON transformation logic into the Rust core (`kreuzberg::utils::json_utils`) and applied it to the FFI layer (`kreuzberg-ffi`). This ensures all metadata returned via FFI (used by Go, Java, C#, etc.) consistently uses `camelCase` for dynamic fields. |
Collaborator
There was a problem hiding this comment.
This doesn't go into the changelog. Only user facing changes go into this .
This PR is a refactor, wholly internal.
Goldziher
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just implemented a centralized solution for the
snake_caseleakage observed across multiple language bindings (Node.js, Go, Java, C#). Instead of fixing casing in each bridge individually, this PR moves the transformation logic into the Rust core and applies it at the FFI layer.changes:
serde_json::Value.camelCasemetadata.