Open
Conversation
ConsistencyLevel support
|
I'd like to be able to pass in the consistency level as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't figure out how to pass in a desired consistency using Database.execute, but it doesn't look like compression is supported that way either, so maybe that's not a big deal. Calling Statement.execute or Database.execute_cql_statement will support it though. It also should be fully backwards-compatible with the old method sigs.
Also, I had to run thrift-client 0.9. I can't remember if that was a Ruby 2 issue or a Cassandra 1.2 issue. At any rate, I've been using it for a while now and, at least for running CQL3 statements, it seems happy enough. You can probably ignore that part of the commit though if you're not ready to trust it yet. It should still work in current environments.